FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix numeric compliance test by HemangChothani · Pull Request #29 · googleapis/python-spanner-sqlalchemy · GitHub

This repository was archived by the owner on May 14, 2026. It is now read-only.
/ python-spanner-sqlalchemy Public archive

test: fix numeric compliance test - #29

Merged
larkee merged 20 commits into
mainfrom
numeric_compliance_test
May 13, 2021
ConversationCommits (20)ChecksFiles changed
Merged

test: fix numeric compliance test#29
larkee merged 20 commits into
mainfrom
numeric_compliance_test

Conversation

HemangChothani commented Mar 16, 2021

Copy link
Copy Markdown
Contributor

No description provided.

HemangChothani requested a review from larkee March 16, 2021 15:32
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 16, 2021
larkee reviewed Mar 22, 2021
View reviewed changes

larkee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There's a lot of skipping relating to decimal which I'm concerned about. Would the changes included in #33 be relevant here?

Comment thread test/test_suite.py Outdated
Comment thread test/test_suite.py Outdated

HemangChothani commented Mar 24, 2021

Copy link
Copy Markdown
Contributor Author

All the tests passes once googleapis/python-spanner#290 PR merged.

skuruppu requested a review from vi3k6i5 April 29, 2021 04:54

vi3k6i5 commented May 4, 2021

Copy link
Copy Markdown
Contributor

Tests look good to me. LGTM.

vi3k6i5 approved these changes May 4, 2021
View reviewed changes

vi3k6i5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Test changes look good to me. Please wait for Skylar's approval before merging.

larkee reviewed May 7, 2021
View reviewed changes

larkee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM other than the nit

Comment thread test/test_suite.py Outdated
larkee reviewed May 10, 2021
View reviewed changes
Comment thread google/cloud/sqlalchemy_spanner/requirements.py Outdated
Comment thread google/cloud/sqlalchemy_spanner/requirements.py Outdated

HemangChothani commented May 11, 2021

Copy link
Copy Markdown
Contributor Author

Failed test will be resolved by PR #62

larkee reviewed May 12, 2021
View reviewed changes
Comment thread test/test_suite.py Outdated
of 38 and scale of 9.
"""
self._do_test(
Numeric(precision=18, scale=12),

larkee May 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We are overriding a number of tests because Spanner does not support scale>9. But these tests still uses Numeric with scale=12 or scale=14. I think it makes sense to change these Numerics to use scale=9. WDYT?

larkee merged commit 06a3844 into main May 13, 2021
IlyaFaer deleted the numeric_compliance_test branch November 17, 2021 10:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
vi3k6i5 vi3k6i5 approved these changes
larkee larkee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL