FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: use empty schema name by default by IlyaFaer · Pull Request #32 · googleapis/python-spanner-sqlalchemy · GitHub

This repository was archived by the owner on May 14, 2026. It is now read-only.
/ python-spanner-sqlalchemy Public archive

fix: use empty schema name by default - #32

Merged
AVaksman merged 14 commits into
mainfrom
get_table_names
Apr 6, 2021
ConversationCommits (14)ChecksFiles changed
Merged

fix: use empty schema name by default#32
AVaksman merged 14 commits into
mainfrom
get_table_names

Conversation

IlyaFaer commented Mar 19, 2021 •
edited
Loading

Copy link
Copy Markdown

The PR is based on another: #24

google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 19, 2021
IlyaFaer commented Mar 19, 2021
View reviewed changes
Comment thread google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py
WHERE table_schema = '{}'
""".format(
schema
schema or ""

IlyaFaer Mar 19, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

By default schema arg is None, so it tried to search for tables with schema 'None'. Not sure how I've written this, it's not smart at all. Fixing it.

IlyaFaer commented Mar 19, 2021
View reviewed changes
Comment thread test/test_suite.py
answer = ["users", "user_tmp", "email_addresses", "dingalings"]
eq_(table_names, answer)
else:
answer = ["dingalings", "email_addresses", "user_tmp", "users"]

IlyaFaer Mar 19, 2021 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

user_tmp is a temporary table, adding it into the expected results

IlyaFaer commented Mar 19, 2021 •
edited
Loading

Copy link
Copy Markdown
Author

@larkee, this PR fixes two more reflection tests. Still, #24 better be merged first.

IlyaFaer requested a review from larkee March 19, 2021 10:35
IlyaFaer mentioned this pull request Mar 19, 2021
Merged
larkee reviewed Mar 23, 2021
View reviewed changes

larkee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Changes introduced in this PR (i.e. schema name and table name test override) LGTM 👍

Approval pending the base PR

AVaksman commented Apr 6, 2021

Copy link
Copy Markdown
Contributor

Merging to unblock further work

AVaksman merged commit f2af0b1 into main Apr 6, 2021
IlyaFaer deleted the get_table_names branch April 6, 2021 10:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
larkee larkee left review comments
AVaksman AVaksman approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL