FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: exclude last_update from the THEN RETURN clause by olavloite · Pull Request #799 · googleapis/python-spanner-sqlalchemy · GitHub

This repository was archived by the owner on May 14, 2026. It is now read-only.

chore: exclude last_update from the THEN RETURN clause - #799

Merged
olavloite merged 1 commit into
mainfrom
run-samples-with-emulator-1.5.42
Nov 10, 2025
Merged

chore: exclude last_update from the THEN RETURN clause#799
olavloite merged 1 commit into
mainfrom
run-samples-with-emulator-1.5.42

Conversation

olavloite commented Nov 10, 2025
edited
Loading

Copy link
Copy Markdown
Contributor

Columns that are assigned a PENDING_COMMIT_TIMESTAMP() value cannot be
included in THEN RETURN clauses.

Fixes this build error: https://github.com/googleapis/python-spanner-sqlalchemy/actions/runs/19180600096/job/54948361746?pr=798

A recent fix in the Emulator caused the samples for SQLAlchemy to start fail. That is not due to a bug in the Emulator, but due to a bug fix in the Emulator. Previously, the Emulator would allow something that would fail on Spanner. That difference has now been fixed.

product-auto-label Bot added api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. samples Issues that are directly related to samples. labels Nov 10, 2025
Columns that are assigned a PENDING_COMMIT_TIMESTAMP() value cannot be
included in THEN RETURN clauses.
olavloite force-pushed the run-samples-with-emulator-1.5.42 branch from 93a258d to c78f13c Compare November 10, 2025 10:04
olavloite changed the title build: run samples with Emulator version 1.5.42 chore: exclude last_update from the THEN RETURN clause Nov 10, 2025
olavloite requested a review from bhatt4982 November 10, 2025 10:11

bhatt4982 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

olavloite merged commit 6cbf00b into main Nov 10, 2025
16 checks passed
olavloite deleted the run-samples-with-emulator-1.5.42 branch November 10, 2025 10:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL