chore: librarian release pull request: 20251215T133347Z - #806
Conversation
Sorry, something went wrong.
Summary of ChangesHello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated release generated by the Librarian CLI for sqlalchemy-spanner version 1.17.2. Its primary purpose is to publish a new version of the library that incorporates a crucial bug fix related to the ordering of columns in compound indexes. Merging this PR will trigger the automated release process, making the updated version available. Highlights
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here. Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request is an automated release PR to bump the version of sqlalchemy-spanner to 1.17.2. The changes include updating the version in the configuration and source code, and adding a new entry to the CHANGELOG.md. The changes are mostly correct, but I've identified issues with the auto-generated links in the CHANGELOG.md file, which currently point to the wrong repository and are broken. My review comments include suggestions to fix these links.
Sorry, something went wrong.
|
|
||
| [1]: https://pypi.org/project/sqlalchemy-spanner/#history | ||
|
|
||
| ## [1.17.2](https://github.com/googleapis/google-cloud-python/compare/sqlalchemy-spanner-v1.17.1...sqlalchemy-spanner-v1.17.2) (2025-12-15) |
There was a problem hiding this comment.
The repository URL and tag format in the version link appear to be incorrect, resulting in a broken link. Based on previous entries and the PR description, the repository should be python-spanner-sqlalchemy and the tags should not be prefixed.
| ## [1.17.2](https://github.com/googleapis/google-cloud-python/compare/sqlalchemy-spanner-v1.17.1...sqlalchemy-spanner-v1.17.2) (2025-12-15) | |
| ## [1.17.2](https://github.com/googleapis/python-spanner-sqlalchemy/compare/v1.17.1...v1.17.2) (2025-12-15) |
Sorry, something went wrong.
|
|
||
| ### Bug Fixes | ||
|
|
||
| * Retrieve columns in compound indexes in correct order (#798) ([9afe49bb720356c58890931c17546650ffd61f88](https://github.com/googleapis/google-cloud-python/commit/9afe49bb720356c58890931c17546650ffd61f88)) |
There was a problem hiding this comment.
The repository URL in the commit link is incorrect, resulting in a broken link. It should point to the python-spanner-sqlalchemy repository. Additionally, for better readability, the link text for the commit should be the short hash, not the full one.
| * Retrieve columns in compound indexes in correct order (#798) ([9afe49bb720356c58890931c17546650ffd61f88](https://github.com/googleapis/google-cloud-python/commit/9afe49bb720356c58890931c17546650ffd61f88)) | |
| * Retrieve columns in compound indexes in correct order (#798) ([9afe49bb](https://github.com/googleapis/python-spanner-sqlalchemy/commit/9afe49bb720356c58890931c17546650ffd61f88)) |
Sorry, something went wrong.
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release.
Librarian Version: v0.7.0
sqlalchemy-spanner: 1.17.2Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620
1.17.2 (2025-12-15)
Bug Fixes