chore: add repo-metadata.json - #849
Conversation
Sorry, something went wrong.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adds a new .repo-metadata.json file to the repository. This file is crucial for defining standardized metadata about the sqlalchemy-spanner project, including its name, documentation links, issue tracker, release level, and language. This addition helps in automated tooling and consistent project information management. Highlights
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here. Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request introduces the .repo-metadata.json file, which is a standard practice for Google Cloud repositories to provide metadata. The information is largely accurate, but there's an inconsistency in the issue_tracker URL. It currently points to Google's Issue Tracker, whereas the project's README.rst directs users to GitHub Issues. I've added a comment to align these for a consistent user experience.
Note: Security Review has been skipped due to the limited scope of the PR.
Sorry, something went wrong.
| "name_pretty": "Spanner dialect for SQLAlchemy", | ||
| "product_documentation": "https://cloud.google.com/spanner/docs", | ||
| "client_documentation": "https://github.com/googleapis/python-spanner-sqlalchemy", | ||
| "issue_tracker": "https://issuetracker.google.com/issues?q=componentid:190851%2B%20status:open", |
There was a problem hiding this comment.
The issue_tracker URL points to Google's Issue Tracker, but the README.rst file (lines 15-17 and 552-553) directs users to file issues on GitHub. To avoid confusion and provide a consistent experience for contributors, this URL should point to the GitHub repository's issues page.
| "issue_tracker": "https://issuetracker.google.com/issues?q=componentid:190851%2B%20status:open", | |
| "issue_tracker": "https://github.com/googleapis/python-spanner-sqlalchemy/issues", |
Sorry, something went wrong.
There was a problem hiding this comment.
https://issuetracker.google.com/issues?q=componentid:190851%2B%20status:open is a public issue tracker
Sorry, something went wrong.
No description provided.