fix(storage): remove expiration strict conversion (#106) · googleapis/python-storage@9550dad · GitHub

This repository was archived by the owner on Mar 31, 2026. It is now read-only.

googleapis / python-storage Public archive

• Notifications You must be signed in to change notification settings
• Fork 173
• Star 503

• Code
• Issues
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 9550dad

Browse filesBrowse the repository at this point in the historyBrowse files

HemangChothani

authored

fix(storage): remove expiration strict conversion (#106)

Fixes #105

1 parent f4de88d commit 9550dad
Copy full SHA for 9550dad

2 files changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• google/cloud/storage
  • _signing.py
• tests/unit
  • test__signing.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎google/cloud/storage/_signing.py‎

Copy file name to clipboardExpand all lines: google/cloud/storage/_signing.py

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -82,7 +82,7 @@ def get_signed_query_params_v2(credentials, expiration, string_to_sign):
82	82	service_account_name = credentials.signer_email
83	83	return {
84	84	"GoogleAccessId": service_account_name,
85		- "Expires": str(expiration),
	85	+ "Expires": expiration,
86	86	"Signature": signature,
87	87	}
88	88
@@ -384,7 +384,7 @@ def generate_signed_url_v2(
384	384	signature = _sign_message(string_to_sign, access_token, service_account_email)
385	385	signed_query_params = {
386	386	"GoogleAccessId": service_account_email,
387		- "Expires": str(expiration),
	387	+ "Expires": expiration_stamp,
388	388	"Signature": signature,
389	389	}
390	390	else:

Collapse file

‎tests/unit/test__signing.py‎

Copy file name to clipboardExpand all lines: tests/unit/test__signing.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -252,7 +252,7 @@ def test_it(self):
252	252
253	253	expected = {
254	254	"GoogleAccessId": account_name,
255		- "Expires": str(expiration),
	255	+ "Expires": expiration,
256	256	"Signature": base64.b64encode(sig_bytes),
257	257	}
258	258	self.assertEqual(result, expected)

0 commit comments

Comments

0 (0)