FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(storage): remove expiration strict conversion by HemangChothani · Pull Request #106 · googleapis/python-storage · GitHub

This repository was archived by the owner on Mar 31, 2026. It is now read-only.
/ python-storage Public archive

fix(storage): remove expiration strict conversion - #106

Merged
gcf-merge-on-green[bot] merged 2 commits into
googleapis:masterfrom
MaxxleLLC:storage_issue_105
Apr 16, 2020
Merged

fix(storage): remove expiration strict conversion#106
gcf-merge-on-green[bot] merged 2 commits into
googleapis:masterfrom
MaxxleLLC:storage_issue_105

Conversation

Copy link
Copy Markdown
Contributor

Fixes #105

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2020

Copy link
Copy Markdown
Contributor Author

Doc is failing because of 100 issue, so first need to merge 103 PR.

frankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @HemangChothani LGTM!

(Thanks @andrewsg for picking up the review)

frankyn added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 16, 2020
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2020

Copy link
Copy Markdown
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment

Copy link
Copy Markdown
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

HemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2020
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2020
gcf-merge-on-green Bot merged commit 9550dad into googleapis:master Apr 16, 2020
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use converted expiration parameter for signed_query_params to generate_signed_url_v2

5 participants


Back | FazBrowse Home | New Git URL