This repository was archived by the owner on Mar 31, 2026. It is now read-only.
feat: add OpenTelemetry Tracing support as a preview feature - #1288
Merged
cojenco merged 6 commits intoJun 26, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
* feat: introduce OpenTelemetry Tracing decorators * update test coverage * add tests, update fixture * update noxfile, extras; remove print * update unit test * review comments
* feat: OTel tracing media ops initial instrumentation * use download class name as span name * avoid asserting filtered warnings from otel per open-telemetry/opentelemetry-python#3164
cojenco
marked this pull request as ready for review
June 18, 2024 21:05
bajajneha27
reviewed
Jun 21, 2024
bajajneha27
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
LGTM with a tiny comment.
I'd let someone else also take a look since I don't know much about it.
Sorry, something went wrong.
Comment thread
google/cloud/storage/_opentelemetry_tracing.py
Outdated
| @@ -0,0 +1,100 @@ | |||
| """Manages OpenTelemetry tracing span creation and handling.""" | |||
Copy link
Copy Markdown
There was a problem hiding this comment.
Copyright and License missing.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Thanks Neha! I've added the copyright notice.
Sorry, something went wrong.
bajajneha27
approved these changes
Jun 24, 2024
andrewsg
suggested changes
Jun 26, 2024
Comment thread
README.rst
Outdated
Comment thread
google/cloud/storage/_opentelemetry_tracing.py
Outdated
andrewsg
approved these changes
Jun 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 more reviewersAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds OpenTelemetry Tracing support as a preview feature, and is subject to change before GA launch.
To enable OpenTelemetry tracing in the python storage client, please refer to the readme for instructions and samples. Feel free to submit bugs and general feedback by opening a github issue.