FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: instrument metadata ops with OTel tracing (#2) by cojenco · Pull Request #1267 · googleapis/python-storage · GitHub

This repository was archived by the owner on Mar 31, 2026. It is now read-only.
/ python-storage Public archive

feat: instrument metadata ops with OTel tracing (#2) - #1267

Merged
cojenco merged 4 commits into
googleapis:otel-tracefrom
cojenco:trace-metadata
May 9, 2024
Merged

feat: instrument metadata ops with OTel tracing (#2)#1267
cojenco merged 4 commits into
googleapis:otel-tracefrom
cojenco:trace-metadata

Conversation

cojenco commented Apr 19, 2024
edited
Loading

Copy link
Copy Markdown
Contributor

part 2

  • instrument metadata operations, as scoped, with OTel tracing decorator
  • rename decorator to create_trace_span per review session
  • add OTel tracing section with instructions in README

Fixes internal b/330755934

cojenco requested review from a team April 19, 2024 20:16
product-auto-label Bot added size: l Pull request size is large. api: storage Issues related to the googleapis/python-storage API. labels Apr 19, 2024
cojenco marked this pull request as draft April 19, 2024 20:20
product-auto-label Bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Apr 25, 2024
cojenco marked this pull request as ready for review April 26, 2024 17:39

andrewsg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One question. Otherwise LGTM. Great text copy in the README.

Comment thread README.rst Outdated
cojenco merged commit 6f70198 into googleapis:otel-trace May 9, 2024
cojenco added a commit that referenced this pull request Jun 26, 2024
* feat: introduce OpenTelemetry Tracing decorators (#1257)

* feat: introduce OpenTelemetry Tracing decorators

* update test coverage

* add tests, update fixture

* update noxfile, extras; remove print

* update unit test

* review comments

* feat: instrument metadata ops with OTel tracing (#2) (#1267)

* feat: instrument metadata ops with Otel tracing

* update README plus test

* update decorator name per review session

* fix typo in readme

* feat: OTel tracing media ops initial instrumentation (#1280)

* feat: OTel tracing media ops initial instrumentation

* use download class name as span name

* avoid asserting filtered warnings from otel per open-telemetry/opentelemetry-python#3164

* add copyright and preview note

* comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL