| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
LGTM thanks for enabling retry by default woohoo
Sorry, something went wrong.
|
PTAL |
Sorry, something went wrong.
There was a problem hiding this comment.
lgtm, thanks!
Sorry, something went wrong.
|
@andrewsg I've noticed that other SDKs (at least Node.js and Go) seem to apply retries only to idempotent operations, as was previously the case in Python. If you don't mind, could you share a bit of insight into the rationale behind this change? |
Sorry, something went wrong.
|
@ishowta The C++ library currently has enabled retries by default on these operations. We are changing our policy around these specific operations to match the C++ library's precedent, starting with Python, but assuming there are no issues, later to include the other languages. We've determined that the potential negative effect of a double request for these listed operations is practically nil and the actual negative effect of having retries off by default is very large, as most people don't use generations or if_generation_match. However, if you do experience an unexpected issue with this change, please do let us know about it. |
Sorry, something went wrong.
|
Thank you for the explanation! In some of our projects, we've been configuring the Cloud Storage SDK to always retry, so I'll use this as a reference. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
No description provided.