FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Retry by default for uploads, blob deletes, metadata updates by andrewsg · Pull Request #1400 · googleapis/python-storage · GitHub

This repository was archived by the owner on Mar 31, 2026. It is now read-only.
/ python-storage Public archive

feat: Retry by default for uploads, blob deletes, metadata updates - #1400

Merged
andrewsg merged 5 commits into
mainfrom
retry-by-default
Jan 24, 2025
Merged

feat: Retry by default for uploads, blob deletes, metadata updates#1400
andrewsg merged 5 commits into
mainfrom
retry-by-default

Conversation

Copy link
Copy Markdown
Contributor

No description provided.

andrewsg requested review from a team December 21, 2024 02:02
product-auto-label Bot added the size: l Pull request size is large. label Dec 21, 2024
product-auto-label Bot added the api: storage Issues related to the googleapis/python-storage API. label Dec 21, 2024

cojenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM thanks for enabling retry by default woohoo

Copy link
Copy Markdown
Contributor Author

PTAL

cojenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm, thanks!

andrewsg merged commit 0426005 into main Jan 24, 2025
andrewsg deleted the retry-by-default branch January 24, 2025 18:28

ishowta commented Feb 6, 2025

Copy link
Copy Markdown

@andrewsg I've noticed that other SDKs (at least Node.js and Go) seem to apply retries only to idempotent operations, as was previously the case in Python. If you don't mind, could you share a bit of insight into the rationale behind this change?

https://github.com/googleapis/nodejs-storage/blob/75c309c0761e4029dcd13024e748d8957052f766/src/storage.ts#L293

https://github.com/googleapis/google-cloud-go/blob/b1e3ce67d97275c7883e2b23617d070981d46bf7/storage/storage.go#L2355

andrewsg commented Feb 6, 2025

Copy link
Copy Markdown
Contributor Author

@ishowta The C++ library currently has enabled retries by default on these operations. We are changing our policy around these specific operations to match the C++ library's precedent, starting with Python, but assuming there are no issues, later to include the other languages. We've determined that the potential negative effect of a double request for these listed operations is practically nil and the actual negative effect of having retries off by default is very large, as most people don't use generations or if_generation_match. However, if you do experience an unexpected issue with this change, please do let us know about it.

ishowta commented Feb 6, 2025

Copy link
Copy Markdown

Thank you for the explanation! In some of our projects, we've been configuring the Cloud Storage SDK to always retry, so I'll use this as a reference.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL