This repository was archived by the owner on Mar 31, 2026. It is now read-only.
feat: add *generation*match args into Blob.compose() - #122
Merged
frankyn merged 14 commits intoJun 9, 2020
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
IlyaFaer
marked this pull request as ready for review
April 30, 2020 13:35
andrewsg
suggested changes
May 5, 2020
frankyn
suggested changes
May 13, 2020
Comment thread
google/cloud/storage/blob.py
added 5 commits
May 15, 2020 01:14
This reverts commit 2ddda40.
…/python-storage into compose_generation_match
andrewsg
suggested changes
May 20, 2020
Comment thread
google/cloud/storage/blob.py
frankyn
approved these changes
May 27, 2020
andrewsg
approved these changes
Jun 2, 2020
andrewsg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
* feat: add *generation*match args into Blob.compose() * add test case with error * new compose surface * Revert "new compose surface" This reverts commit 2ddda40. * add an error for different length args, add a usage example * add condition to avoid sending params with None * specify comments Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
* feat: add *generation*match args into Blob.compose() * add test case with error * new compose surface * Revert "new compose surface" This reverts commit 2ddda40. * add an error for different length args, add a usage example * add condition to avoid sending params with None * specify comments Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ifGenerationMatch and ifMetagenerationMatch arguments into Blob.compose() method.
Towards #127