This repository was archived by the owner on Mar 31, 2026. It is now read-only.
fix: correct notification error message - #1290
Merged
tritone merged 1 commit intoJun 17, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
To create a new notification, the notification_id field must be set to None. Update the error message to clarify this. Fixes googleapis#1289
andrewsg
approved these changes
Jun 17, 2024
Copy link
Copy Markdown
Contributor
|
Thank you! Please feel free to merge directly, or ask me to merge, when you're ready. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To create a new notification, the notification_id field must be set to None. Update the error message to clarify this.
Fixes #1289
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕