FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

samples: Add samples for soft_deleted_buckets by chandra-siri · Pull Request #1463 · googleapis/python-storage · GitHub

This repository was archived by the owner on Mar 31, 2026. It is now read-only.
/ python-storage Public archive

samples: Add samples for soft_deleted_buckets - #1463

Merged
chandra-siri merged 14 commits into
mainfrom
1455-samples-for-bucket-restore
May 6, 2025
ConversationCommits (14)ChecksFiles changed
Merged

samples: Add samples for soft_deleted_buckets#1463
chandra-siri merged 14 commits into
mainfrom
1455-samples-for-bucket-restore

Conversation

chandra-siri commented Apr 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea.

    yes - Samples for Bucket Restore #1455

  • Ensure the tests and linter pass

  • Code coverage does not decrease (if any source code was changed)
    No source code changed.

  • Appropriate docs were updated (if necessary) - NA

Fixes #1455

chandra-siri requested a review from a team as a code owner April 16, 2025 09:20
chandra-siri requested review from a team and holtskinner April 16, 2025 09:20
chandra-siri linked an issue Apr 16, 2025 that may be closed by this pull request
Samples for Bucket Restore #1455
Closed

snippet-bot Bot commented Apr 16, 2025 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

product-auto-label Bot added the size: m Pull request size is medium. label Apr 16, 2025
product-auto-label Bot added api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels Apr 16, 2025
JesseLovelace previously requested changes Apr 16, 2025
View reviewed changes

JesseLovelace left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

All samples need to have tests, please add them

Comment thread samples/snippets/storage_get_soft_deleted_bucket.py Outdated
Comment thread samples/snippets/storage_get_soft_deleted_bucket.py Outdated
Comment thread samples/snippets/storage_list_buckets.py

chandra-siri commented Apr 18, 2025

Copy link
Copy Markdown
Collaborator Author

All samples need to have tests, please add them

Done. @JesseLovelace Please check.

chandra-siri requested a review from cojenco April 21, 2025 08:18
chandra-siri changed the title samples: Add samples for soft_deleted_buckets chore: Add samples for soft_deleted_buckets Apr 22, 2025
chandra-siri changed the title chore: Add samples for soft_deleted_buckets samples: Add samples for soft_deleted_buckets Apr 22, 2025
bajajneha27 approved these changes Apr 30, 2025
View reviewed changes

bajajneha27 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Overall LGTM from feature perspective, just two nit comments.

Comment thread samples/snippets/storage_get_soft_deleted_bucket.py Outdated
Comment thread samples/snippets/storage_get_soft_deleted_bucket.py Outdated
cojenco approved these changes May 1, 2025
View reviewed changes

cojenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A few comments and questions, otherwise LGTM too

Comment thread samples/snippets/storage_get_soft_deleted_bucket.py Outdated
Comment thread samples/snippets/storage_list_soft_deleted_buckets.py Outdated
Comment thread samples/snippets/storage_restore_soft_deleted_bucket.py Outdated
Comment thread samples/snippets/storage_restore_soft_deleted_bucket.py
chandra-siri requested a review from JesseLovelace May 5, 2025 10:02
chandra-siri requested review from a team, holtskinner and leahecole and removed request for a team, holtskinner and leahecole May 5, 2025 10:03
holtskinner removed their request for review May 5, 2025 15:20
holtskinner requested review from JesseLovelace and removed request for JesseLovelace May 5, 2025 15:21
chandra-siri dismissed JesseLovelace’s stale review May 6, 2025 13:28

Already got approvals from 3 People.

chandra-siri merged commit 5cfb7a5 into main May 6, 2025
chandra-siri deleted the 1455-samples-for-bucket-restore branch May 6, 2025 15:50
cojenco mentioned this pull request Jun 5, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

JesseLovelace Awaiting requested review from JesseLovelace
3 more reviewers
bajajneha27 bajajneha27 approved these changes
holtskinner holtskinner approved these changes
cojenco cojenco approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

cojenco

Labels

api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Samples for Bucket Restore

5 participants

Back | FazBrowse Home | New Git URL