FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

samples: Add samples for async download files #1470 by chandra-siri · Pull Request #1471 · googleapis/python-storage · GitHub

This repository was archived by the owner on Mar 31, 2026. It is now read-only.
/ python-storage Public archive

samples: Add samples for async download files #1470 - #1471

Merged
chandra-siri merged 10 commits into
googleapis:mainfrom
chandra-siri:1470-samples-for-async-downloads
May 5, 2025
ConversationCommits (10)ChecksFiles changed
Merged

samples: Add samples for async download files #1470#1471
chandra-siri merged 10 commits into
googleapis:mainfrom
chandra-siri:1470-samples-for-async-downloads

Conversation

chandra-siri commented Apr 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary) - NA

Fixes #1470

chandra-siri requested a review from a team as a code owner April 25, 2025 05:06
chandra-siri requested review from a team and nicain April 25, 2025 05:06
product-auto-label Bot added the size: m Pull request size is medium. label Apr 25, 2025

snippet-bot Bot commented Apr 25, 2025 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

product-auto-label Bot added api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels Apr 25, 2025
chandra-siri requested a review from cojenco April 25, 2025 05:20
chandra-siri added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2025
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2025
chandra-siri added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 25, 2025
yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 25, 2025
cojenco reviewed Apr 25, 2025
View reviewed changes

cojenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for adding this! The sample LGTM. Left a few comments; Feel free to let me know if you have any questions.

Comment thread samples/snippets/storage_async_download.py
Comment thread samples/snippets/storage_async_download.py Outdated
Comment thread samples/snippets/storage_async_download.py Outdated
Comment thread samples/snippets/storage_async_download.py Outdated
cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2025
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2025

cojenco commented Apr 25, 2025

Copy link
Copy Markdown
Contributor

Added the label kokoro:force-run to rerun the presubmit tests.

The tests are passing now that the core library team fixed a key rotation in one of the kokoro projects, fyi internal b/413445927

bajajneha27 reviewed Apr 28, 2025
View reviewed changes
Comment thread samples/snippets/storage_async_download.py
Comment thread samples/snippets/storage_async_download.py
Comment thread samples/snippets/storage_async_download.py Outdated
cojenco approved these changes Apr 29, 2025
View reviewed changes

cojenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please address the unresolved comments before merging; otherwise LGTM, thanks!

cojenco reviewed Apr 29, 2025
View reviewed changes
Comment thread samples/snippets/storage_async_download.py Outdated
bajajneha27 approved these changes Apr 30, 2025
View reviewed changes

bajajneha27 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Please resolve the pending comments.

Comment thread samples/snippets/storage_async_download.py Outdated
Comment thread samples/snippets/storage_async_download.py Outdated
cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label May 1, 2025
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 1, 2025
bajajneha27 approved these changes May 2, 2025
View reviewed changes
Comment thread samples/snippets/storage_async_download.py Outdated
chandra-siri enabled auto-merge (squash) May 5, 2025 05:19
chandra-siri added the owlbot:run Add this label to trigger the Owlbot post processor. label May 5, 2025
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 5, 2025
chandra-siri merged commit 8f56cc8 into googleapis:main May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

nicain Awaiting requested review from nicain nicain is a code owner automatically assigned from googleapis/python-samples-reviewers
2 more reviewers
cojenco cojenco approved these changes
bajajneha27 bajajneha27 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

cojenco

Labels

api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add samples for async download files

4 participants

Back | FazBrowse Home | New Git URL