FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: make the gapic code private by Pulkit0110 · Pull Request #1519 · googleapis/python-storage · GitHub

This repository was archived by the owner on Mar 31, 2026. It is now read-only.
/ python-storage Public archive

chore: make the gapic code private - #1519

Merged
Pulkit0110 merged 3 commits into
googleapis:mainfrom
Pulkit0110:make-gapic-private
Aug 25, 2025
Merged

chore: make the gapic code private#1519
Pulkit0110 merged 3 commits into
googleapis:mainfrom
Pulkit0110:make-gapic-private

Conversation

Copy link
Copy Markdown
Contributor

Changing the gapic directory from storage_v2 to _storage_v2 so that it acts as a private folder.

Pulkit0110 requested review from a team and chandra-siri August 12, 2025 08:55
product-auto-label Bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Aug 12, 2025

chalmerlowe commented Aug 12, 2025
edited
Loading

Copy link
Copy Markdown
Contributor

@Pulkit0110

I am curious:

  • What are our reasons for suggesting this change to a private folder?
  • Are there benefits to this that you see?
  • Are there disadvantages to leaving the folder as is?

My understanding has always been that the folder names for all the GAPIC generated code are automatically created by the GAPIC generator and customarily use the format google/cloud/{packagename_v#}.

If that is the case, then changing the format here may not be a lasting change next time the GAPIC generated code gets rebuilt.

Relatedly, there are 60+ references to storage_v2 in this code base alone (especially in tests, etc). For example: from google.cloud import storage_v2

If the change to a new folder naming convention is approved, should those also be changed to _storage_v2?

Any insight you can offer is appreciated.

Copy link
Copy Markdown
Contributor

@chalmerlowe We're not exposing the gapic directly to customers -- thus moving this to a private folder makes sense. The plan is to write a veneer over the GAPIC client. See details here: go/storage-python-grpc & go/bidi-reads-py-sdk

Pulkit0110 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 25, 2025
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 25, 2025
Pulkit0110 merged commit 04b01ed into googleapis:main Aug 25, 2025
15 checks passed
Pulkit0110 deleted the make-gapic-private branch January 2, 2026 11:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL