This repository was archived by the owner on Mar 31, 2026. It is now read-only.
feat: add mtls support - #367
Merged
arithmetic1728 merged 9 commits intoFeb 10, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
arithmetic1728
force-pushed
the
for_mtls
branch
from
79b5dd2 to
9ac0063
Compare
January 28, 2021 01:49
arithmetic1728
force-pushed
the
for_mtls
branch
from
2bf1118 to
01a97a2
Compare
January 29, 2021 10:35
arithmetic1728
marked this pull request as ready for review
January 31, 2021 12:50
andrewsg
suggested changes
Feb 9, 2021
Comment thread
google/cloud/storage/_http.py
Comment thread
google/cloud/storage/_http.py
Comment thread
google/cloud/storage/_http.py
Outdated
Comment thread
google/cloud/storage/blob.py
Outdated
frankyn
suggested changes
Feb 9, 2021
Comment thread
google/cloud/storage/_http.py
Outdated
Comment thread
tests/unit/test__http.py
Comment thread
tests/system/test_system.py
Comment thread
tests/system/test_system.py
frankyn
suggested changes
Feb 10, 2021
Comment thread
google/cloud/storage/blob.py
Outdated
Comment thread
tests/system/test_system.py
Comment thread
tests/system/test_system.py
frankyn
approved these changes
Feb 10, 2021
andrewsg
approved these changes
Feb 10, 2021
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
* feat: add mtls support * update * update * update * update * update
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
* feat: add mtls support * update * update * update * update * update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://google.aip.dev/auth/4114
googlers see go/mtls-python-cloud-core-clients for more details.
Part of the mtls feature is implemented in googleapis/python-cloud-core#75, and will be released as version 1.16.0.
This PR adds the mtls feature to storage client lib. Note that:
(1) if the python-cloud-core version is < 1.16.0, this PR does nothing, it is backward compatible and won't break any current users.
(2) if the user sets GOOGLE_API_USE_CLIENT_CERTIFICATE env var to "true" to trigger mtls, then the PR checks python-cloud-core version. It throws an exception asking the user to bump the version, if the version < 1.16.0. So probably it is a good idea to release python-cloud-core 1.16.0 before merging this PR.
(3) the unit tests work for both python-cloud-core versions, so unit test shouldn't break after the upgrading in the future.
(4) for mtls testing (running internally), we need to skip a couple of system tests: