FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add Prefixer class to generate and parse resource names by tswast · Pull Request #39 · googleapis/python-test-utils · GitHub

This repository was archived by the owner on Feb 9, 2026. It is now read-only.
/ python-test-utils Public archive

feat: add Prefixer class to generate and parse resource names - #39

Merged
tseaver merged 5 commits into
masterfrom
issue10-resource-prefixes
Jul 7, 2021
ConversationCommits (5)ChecksFiles changed
Merged

feat: add Prefixer class to generate and parse resource names#39
tseaver merged 5 commits into
masterfrom
issue10-resource-prefixes

Conversation

tswast commented Jul 2, 2021

Copy link
Copy Markdown
Contributor

This Prefixer class is intended to be created once per test file and/or test suite (such as in a conftest.py file). It can be used to generate standard resource names, which can easily identify which test suite created them. Also, since they contain the UTC date/time that the resource was created to facilitate cleanup fixtures.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #10 🦕

tswast requested a review from a team July 2, 2021 21:48
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 2, 2021
tseaver suggested changes Jul 6, 2021
View reviewed changes
Comment thread test_utils/prefixer.py Outdated
Comment thread test_utils/prefixer.py Outdated
use compiled sub method
232deb8 
Co-authored-by: Tres Seaver <tseaver@palladion.com>

google-cla Bot commented Jul 7, 2021

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla Bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 7, 2021
add summary docstring
e55c0e0 
Co-authored-by: Tres Seaver <tseaver@palladion.com>

google-cla Bot commented Jul 7, 2021

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

tswast added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 7, 2021
tswast requested a review from tseaver July 7, 2021 14:14

google-cla Bot commented Jul 7, 2021

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla Bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 7, 2021
tswast added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 7, 2021
tseaver merged commit 865480b into master Jul 7, 2021
tseaver deleted the issue10-resource-prefixes branch July 7, 2021 17:46
tswast mentioned this pull request Jul 8, 2021
Closed
plamut reviewed Jul 9, 2021
View reviewed changes
Comment thread tests/unit/test_prefixer.py
Comment on lines +24 to +26
"""Fake datetime class since pytest can't monkeypatch attributes of
built-in/extension type.
"""

plamut Jul 9, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Would using freezegun represent a viable alternative?

True, it would be a new dependency, but it's widely used and maintained, and supports a wide range of features.

(the downside is that the more recent versions require Python 3.5+, but it could still be an option when Python 2.7 support is finally dropped in all libraries)

tswast Jul 15, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah, freezegun would have been the more robust choice. Indeed, I didn't want to introduce a new dependency just for this.

tswast mentioned this pull request Jul 15, 2021
Merged
gcf-merge-on-green Bot pushed a commit to googleapis/python-bigquery that referenced this pull request Jul 16, 2021
docs: add loading data from Firestore backup sample (#737)
22fd848 
Follow-up to #736

To be included here: https://cloud.google.com/bigquery/docs/loading-data-cloud-firestore

Also

* Use `google-cloud-testutils` for cleanup as described in googleapis/python-test-utils#39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
plamut plamut left review comments
tseaver tseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

methods to create and parse standard resource prefixes with repo_name, directory_path as parameters

3 participants

Back | FazBrowse Home | New Git URL