FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: remove java-common-protos/.kokoro and enable renovate bot for requirements file. by mpeddada1 · Pull Request #1584 · googleapis/sdk-platform-java · GitHub

This repository was archived by the owner on May 14, 2026. It is now read-only.
/ sdk-platform-java Public archive

chore: remove java-common-protos/.kokoro and enable renovate bot for requirements file. - #1584

Merged
mpeddada1 merged 12 commits into
mainfrom
clean-up-requirements
Mar 31, 2023
ConversationCommits (12)ChecksFiles changed
Merged

chore: remove java-common-protos/.kokoro and enable renovate bot for requirements file. #1584
mpeddada1 merged 12 commits into
mainfrom
clean-up-requirements

Conversation

mpeddada1 commented Mar 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #1485

Notable changes:

mpeddada1 requested a review from a team March 29, 2023 21:55
product-auto-label Bot added the size: m Pull request size is medium. label Mar 29, 2023
product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 29, 2023
mpeddada1 changed the title chore: unpin versions in requirements.in and enable renovate bot chore: upgrade cryptography and certifi versions in requirements.in and enable renovate bot Mar 29, 2023
mpeddada1 requested a review from meltsufin March 30, 2023 14:26
suztomo suggested changes Mar 30, 2023
View reviewed changes

suztomo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We don't use java-common-protos/.kokoro. (Let me know if you think otherwise)

Would you add a check (either this PR or another PR) to ensure these requirements files can be installed. It's great if we can use the same container image as we use in the release job.

mpeddada1 commented Mar 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

We don't use java-common-protos/.kokoro. (Let me know if you think otherwise)

Not sure if this is expected but I see that the nightly and presubmit jobs are still running but the release jobs haven't been executed since Nov, 2022. Does that mean that the .kokoro/release scripts for java-common-protos can be removed?

UPDATE:
Looking at the build log, these jobs are running for the old repo.

Would you add a check (either this PR or another PR) to ensure these requirements files can be installed. It's great if we can use the same container image as we use in the release job.

Sure! I'll work on adding the check in.

mpeddada1 requested a review from suztomo March 30, 2023 15:10
product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Mar 31, 2023
product-auto-label Bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Mar 31, 2023

mpeddada1 commented Mar 31, 2023

Copy link
Copy Markdown
Contributor Author

@suztomo I've removed the .kokoro directory from java-common-protos and added a check for requirements.txt. Could I get another review from you?

mpeddada1 changed the title chore: upgrade cryptography and certifi versions in requirements.in and enable renovate bot chore: remove java-common-protos/.kokoro and enable renovate bot for requirements file. Mar 31, 2023
suztomo reviewed Mar 31, 2023
View reviewed changes
Comment thread .github/workflows/ci.yaml
steps:
- uses: actions/checkout@v3
- run: python3 --version
- run: python3 -m pip install --require-hashes -r .kokoro/requirements.txt

suztomo Mar 31, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Great. Can you also add check to confirm releasetool module import?

suztomo approved these changes Mar 31, 2023
View reviewed changes

suztomo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you. Merge once all are green.

sonarqubecloud Bot commented Mar 31, 2023

Copy link
Copy Markdown

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

sonarqubecloud Bot commented Mar 31, 2023

Copy link
Copy Markdown

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

sonarqubecloud Bot commented Mar 31, 2023

Copy link
Copy Markdown

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

mpeddada1 merged commit 2c2087c into main Mar 31, 2023
mpeddada1 deleted the clean-up-requirements branch March 31, 2023 19:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

meltsufin Awaiting requested review from meltsufin
1 more reviewer
suztomo suztomo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update cryptography and certifi to resolve dependabot security alerts.

2 participants

Back | FazBrowse Home | New Git URL