FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: [iam] upgrading Protobuf to 23.1 and gRPC to 1.55.0 in code generation by gcf-owl-bot[bot] · Pull Request #1693 · googleapis/sdk-platform-java · GitHub

This repository was archived by the owner on May 14, 2026. It is now read-only.

chore: [iam] upgrading Protobuf to 23.1 and gRPC to 1.55.0 in code generation - #1693

Merged
suztomo merged 7 commits into
mainfrom
owl-bot-copy-java-iam
May 24, 2023
Merged

chore: [iam] upgrading Protobuf to 23.1 and gRPC to 1.55.0 in code generation#1693
suztomo merged 7 commits into
mainfrom
owl-bot-copy-java-iam

Conversation

gcf-owl-bot Bot commented May 22, 2023
edited
Loading

Copy link
Copy Markdown
Contributor
  • Regenerate this pull request now.

PiperOrigin-RevId: 534084593

Source-Link: googleapis/googleapis@aa4559a

Source-Link: https://github.com/googleapis/googleapis-gen/commit/370325af8236732f5885f5940e0ef481fee83003
Copy-Tag: eyJwIjoiamF2YS1pYW0vLk93bEJvdC55YW1sIiwiaCI6IjM3MDMyNWFmODIzNjczMmY1ODg1ZjU5NDBlMGVmNDgxZmVlODMwMDMifQ==

gcf-owl-bot Bot requested a review from a team May 22, 2023 18:50
trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 22, 2023
product-auto-label Bot added the size: xl Pull request size is extra large. label May 22, 2023
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2023
trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2023
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2023

Copy link
Copy Markdown
Contributor

Need to merge this PR in first: #1698

gcf-owl-bot Bot commented May 23, 2023

Copy link
Copy Markdown
Contributor Author

Owl bot is regenerating pull request 1693...
Build name: YzU2Zjc2YTEtMDMwNy00OGY4LTgxM2QtMTY2MDliZmJjZTBj

PiperOrigin-RevId: 534084593

Source-Link: googleapis/googleapis@aa4559a

Source-Link: https://github.com/googleapis/googleapis-gen/commit/370325af8236732f5885f5940e0ef481fee83003
Copy-Tag: eyJwIjoiamF2YS1pYW0vLk93bEJvdC55YW1sIiwiaCI6IjM3MDMyNWFmODIzNjczMmY1ODg1ZjU5NDBlMGVmNDgxZmVlODMwMDMifQ==
gcf-owl-bot Bot force-pushed the owl-bot-copy-java-iam branch from 5df53cf to e12f449 Compare May 23, 2023 17:43
trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023

mpeddada1 commented May 23, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

Stacktrace from ci / build(8):

Error:  7002: com.google.iam.v1.TestIamPermissionsResponse$Builder: Method 'public com.google.iam.v1.TestIamPermissionsResponse$Builder clearOneof(com.google.protobuf.Descriptors$OneofDescriptor)' has been removed
Error:  7002: com.google.iam.v1.TestIamPermissionsResponse$Builder: Method 'public com.google.iam.v1.TestIamPermissionsResponse$Builder clone()' has been removed
Error:  7002: com.google.iam.v1.TestIamPermissionsResponse$Builder: Method 'public com.google.iam.v1.TestIamPermissionsResponse$Builder setField(com.google.protobuf.Descriptors$FieldDescriptor, java.lang.Object)' has been removed
Error:  7002: com.google.iam.v1.TestIamPermissionsResponse$Builder: Method 'public com.google.iam.v1.TestIamPermissionsResponse$Builder setRepeatedField(com.google.protobuf.Descriptors$FieldDescriptor, int, java.lang.Object)' has been removed

Even though protobuf 3.23.1 and 1.55.1 are brought in.

suztomo commented May 23, 2023

Copy link
Copy Markdown
Member

Pasted all errors http://gpaste/6136580984012800

Copy link
Copy Markdown
Contributor

The methods being removed are expected to rely on the parent class directly. As an example, confirmed that methods that were removed in AuditConfigDelta are indeed defined in the parent class, GeneratedMessageV3.

trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023

Copy link
Copy Markdown
Contributor

@suztomo I've added exclusions to https://github.com/googleapis/sdk-platform-java/blob/main/java-iam/proto-google-iam-v1/clirr-ignored-differences.xml to get past the failures. Could I get a review on this please?

mpeddada1 requested a review from suztomo May 23, 2023 22:12

Copy link
Copy Markdown

[gapic-generator-java-root] SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
46 Code Smells

0.0% Coverage
62.8% Duplication

Copy link
Copy Markdown

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

Copy link
Copy Markdown

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

suztomo merged commit ff3c154 into main May 24, 2023
suztomo deleted the owl-bot-copy-java-iam branch May 24, 2023 02:10
mpeddada1 added a commit that referenced this pull request May 25, 2023
mpeddada1 added a commit that referenced this pull request May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

kokoro:force-run Add this label to force Kokoro to re-run the tests. owl-bot-copy size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL