FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: update tag workflow by alicejli · Pull Request #1699 · googleapis/sdk-platform-java · GitHub

This repository was archived by the owner on May 14, 2026. It is now read-only.
/ sdk-platform-java Public archive

fix: update tag workflow - #1699

Merged
alicejli merged 2 commits into
mainfrom
updateReleaseTagWorkflow
May 23, 2023
ConversationCommits (2)ChecksFiles changed
Merged

fix: update tag workflow#1699
alicejli merged 2 commits into
mainfrom
updateReleaseTagWorkflow

Conversation

alicejli commented May 23, 2023

Copy link
Copy Markdown
Contributor

Replacement for #1695

This fixes a couple issues with the original workflow:

  1. Skips tags that are already created instead of failing
  2. Uses exact matches for artifact IDs (multiple artifacts that begin with gax were causing issues)
  3. Removes manual input for manual trigger; will automatically take the latest release which is what we want.

alicejli requested a review from a team May 23, 2023 18:25
product-auto-label Bot added the size: s Pull request size is small. label May 23, 2023
alicejli requested a review from suztomo May 23, 2023 18:26
suztomo suggested changes May 23, 2023
View reviewed changes
Comment thread .github/workflows/create_additional_release_tag.yaml Outdated

sonarqubecloud Bot commented May 23, 2023

Copy link
Copy Markdown

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

sonarqubecloud Bot commented May 23, 2023

Copy link
Copy Markdown

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

sonarqubecloud Bot commented May 23, 2023

Copy link
Copy Markdown

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

alicejli merged commit a988fe7 into main May 23, 2023
alicejli deleted the updateReleaseTagWorkflow branch May 23, 2023 20:16
release-please Bot mentioned this pull request May 23, 2023
Merged
alicejli mentioned this pull request May 23, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
suztomo suztomo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL