FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: opentelemetry-bom to be in third-party-dependencies BOM by suztomo · Pull Request #2736 · googleapis/sdk-platform-java · GitHub

This repository was archived by the owner on May 14, 2026. It is now read-only.
/ sdk-platform-java Public archive

fix: opentelemetry-bom to be in third-party-dependencies BOM - #2736

Merged
suztomo merged 1 commit into
mainfrom
fix_opentelemetry-bom_location
May 9, 2024
ConversationCommits (1)ChecksFiles changed
Merged

fix: opentelemetry-bom to be in third-party-dependencies BOM#2736
suztomo merged 1 commit into
mainfrom
fix_opentelemetry-bom_location

Conversation

suztomo commented May 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Importing opentelemetry-bom in gapic-generator-java-bom (and thus Google Cloud Libraries BOM) wrongly implies that we (Google) publish the OpenTelemetry artifacts.

https://jlbp.dev/JLBP-15 states:

Your project's BOM should not include any of your dependencies on other libraries.

In this change, the opentelemetry-bom is declared in the third-party-dependencies BOM and thus will be excluded in the Google Cloud Libraries BOM, which does not import the third-party-dependencies BOM.

Related to b/338624813

fix: opentelemetry-bom to be in third-party-dependencies BOM
37337cc 
Importing opentelemetry-bom in gapic-generator-java-bom wrongly
implies that we (Google) publish the OpenTelemetry artifacts.

https://jlbp.dev/JLBP-15 states:
  Your project's BOM should not include any of your dependencies
  on other libraries.

In this change, the opentelemetry-bom is declared in the third-
party-dependencies BOM and thus will be excluded in the Google
Cloud Libraries BOM.
suztomo requested a review from a team May 6, 2024 02:29
product-auto-label Bot added the size: s Pull request size is small. label May 6, 2024

sonarqubecloud Bot commented May 6, 2024

Copy link
Copy Markdown

Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud Bot commented May 6, 2024

Copy link
Copy Markdown

Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

suztomo merged commit 4ecc89b into main May 9, 2024
suztomo deleted the fix_opentelemetry-bom_location branch May 9, 2024 20:26
release-please Bot mentioned this pull request May 9, 2024
Merged
alicejli mentioned this pull request May 9, 2024
Merged
JoeWang1127 added a commit that referenced this pull request May 16, 2024
chore(main): release 2.40.1 (#2729)
dadb6b9 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.40.1</summary>

##
[2.40.1](v2.40.0...v2.40.1)
(2024-05-15)


### Bug Fixes

* [common-protos] An existing method `UpdateVehicleLocation` is
([7f96074](7f96074))
* [common-protos] An existing method `UpdateVehicleLocation` is removed
from service `VehicleService`
([#2751](#2751))
([7f96074](7f96074))
* [iam] An existing method `UpdateVehicleLocation` is removed from
([4a1ae7b](4a1ae7b))
* [iam] An existing method `UpdateVehicleLocation` is removed from
service `VehicleService`
([#2752](#2752))
([4a1ae7b](4a1ae7b))
* do not populate repo level change while removing library
([#2740](#2740))
([43e62b9](43e62b9))
* only append `.api.grpc` suffix to group id if the artifact id starts
with `proto-` or `grpc-`
([#2731](#2731))
([8e87b2e](8e87b2e))
* opentelemetry-bom to be in third-party-dependencies BOM
([#2736](#2736))
([4ecc89b](4ecc89b))
* prepare to generate grafeas
([#2761](#2761))
([1114f18](1114f18))
* Replace deprecated protobuf methods.
([#2764](#2764))
([986c090](986c090))


### Dependencies

* update dependency black to v24.4.2
([#2660](#2660))
([1cbb681](1cbb681))
* update dependency com.fasterxml.jackson:jackson-bom to v2.17.1
([#2732](#2732))
([891b01d](891b01d))
* update dependency com.google.cloud:grpc-gcp to v1.6.0
([#2767](#2767))
([a39aa07](a39aa07))
* update dependency com.google.errorprone:error_prone_annotations to
v2.27.1
([#2708](#2708))
([4d7d246](4d7d246))
* update dependency com.google.errorprone:error_prone_annotations to
v2.27.1
([#2709](#2709))
([4e31d7d](4e31d7d))
* update dependency com.google.oauth-client:google-oauth-client-bom to
v1.36.0
([#2768](#2768))
([22b7398](22b7398))
* update dependency commons-codec:commons-codec to v1.17.0
([#2710](#2710))
([b87356c](b87356c))
* update dependency jinja2 to v3.1.4 [security]
([#2742](#2742))
([d67eaf8](d67eaf8))
* update dependency lxml to v5.2.2
([#2766](#2766))
([df7e211](df7e211))
* update dependency markupsafe to v2.1.5
([#2657](#2657))
([805baf8](805baf8))
* update dependency net.bytebuddy:byte-buddy to v1.14.15
([#2753](#2753))
([a472620](a472620))
* update dependency platformdirs to v4.2.1
([#2662](#2662))
([dbdcc91](dbdcc91))
* update googleapis/java-cloud-bom digest to db4265f
([#2755](#2755))
([908db6f](908db6f))
* update googleapis/java-cloud-bom digest to f3c611a
([#2700](#2700))
([d254e9b](d254e9b))
* update opentelemetry-java monorepo to v1.38.0
([#2769](#2769))
([0a5c7c4](0a5c7c4))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Joe Wang <106995533+JoeWang1127@users.noreply.github.com>
lqiu96 pushed a commit that referenced this pull request May 16, 2024
chore(main): release 2.40.1 (#2729)
7d6754e 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.40.1</summary>

##
[2.40.1](v2.40.0...v2.40.1)
(2024-05-15)


### Bug Fixes

* [common-protos] An existing method `UpdateVehicleLocation` is
([7f96074](7f96074))
* [common-protos] An existing method `UpdateVehicleLocation` is removed
from service `VehicleService`
([#2751](#2751))
([7f96074](7f96074))
* [iam] An existing method `UpdateVehicleLocation` is removed from
([4a1ae7b](4a1ae7b))
* [iam] An existing method `UpdateVehicleLocation` is removed from
service `VehicleService`
([#2752](#2752))
([4a1ae7b](4a1ae7b))
* do not populate repo level change while removing library
([#2740](#2740))
([43e62b9](43e62b9))
* only append `.api.grpc` suffix to group id if the artifact id starts
with `proto-` or `grpc-`
([#2731](#2731))
([8e87b2e](8e87b2e))
* opentelemetry-bom to be in third-party-dependencies BOM
([#2736](#2736))
([4ecc89b](4ecc89b))
* prepare to generate grafeas
([#2761](#2761))
([1114f18](1114f18))
* Replace deprecated protobuf methods.
([#2764](#2764))
([986c090](986c090))


### Dependencies

* update dependency black to v24.4.2
([#2660](#2660))
([1cbb681](1cbb681))
* update dependency com.fasterxml.jackson:jackson-bom to v2.17.1
([#2732](#2732))
([891b01d](891b01d))
* update dependency com.google.cloud:grpc-gcp to v1.6.0
([#2767](#2767))
([a39aa07](a39aa07))
* update dependency com.google.errorprone:error_prone_annotations to
v2.27.1
([#2708](#2708))
([4d7d246](4d7d246))
* update dependency com.google.errorprone:error_prone_annotations to
v2.27.1
([#2709](#2709))
([4e31d7d](4e31d7d))
* update dependency com.google.oauth-client:google-oauth-client-bom to
v1.36.0
([#2768](#2768))
([22b7398](22b7398))
* update dependency commons-codec:commons-codec to v1.17.0
([#2710](#2710))
([b87356c](b87356c))
* update dependency jinja2 to v3.1.4 [security]
([#2742](#2742))
([d67eaf8](d67eaf8))
* update dependency lxml to v5.2.2
([#2766](#2766))
([df7e211](df7e211))
* update dependency markupsafe to v2.1.5
([#2657](#2657))
([805baf8](805baf8))
* update dependency net.bytebuddy:byte-buddy to v1.14.15
([#2753](#2753))
([a472620](a472620))
* update dependency platformdirs to v4.2.1
([#2662](#2662))
([dbdcc91](dbdcc91))
* update googleapis/java-cloud-bom digest to db4265f
([#2755](#2755))
([908db6f](908db6f))
* update googleapis/java-cloud-bom digest to f3c611a
([#2700](#2700))
([d254e9b](d254e9b))
* update opentelemetry-java monorepo to v1.38.0
([#2769](#2769))
([0a5c7c4](0a5c7c4))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Joe Wang <106995533+JoeWang1127@users.noreply.github.com>
lqiu96 pushed a commit that referenced this pull request May 22, 2024
fix: opentelemetry-bom to be in third-party-dependencies BOM (#2736)
9256ada 
Importing opentelemetry-bom in gapic-generator-java-bom (and thus Google
Cloud Libraries BOM) wrongly implies that we (Google) publish the
OpenTelemetry artifacts.

https://jlbp.dev/JLBP-15 states:

> Your project's BOM should not include any of your dependencies on
other libraries.

In this change, the opentelemetry-bom is declared in the
third-party-dependencies BOM and thus will be excluded in the Google
Cloud Libraries BOM, which does not import the third-party-dependencies
BOM.

Related to b/338624813
lqiu96 pushed a commit that referenced this pull request May 22, 2024
chore(main): release 2.40.1 (#2729)
796565a 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.40.1</summary>

##
[2.40.1](v2.40.0...v2.40.1)
(2024-05-15)


### Bug Fixes

* [common-protos] An existing method `UpdateVehicleLocation` is
([7f96074](7f96074))
* [common-protos] An existing method `UpdateVehicleLocation` is removed
from service `VehicleService`
([#2751](#2751))
([7f96074](7f96074))
* [iam] An existing method `UpdateVehicleLocation` is removed from
([4a1ae7b](4a1ae7b))
* [iam] An existing method `UpdateVehicleLocation` is removed from
service `VehicleService`
([#2752](#2752))
([4a1ae7b](4a1ae7b))
* do not populate repo level change while removing library
([#2740](#2740))
([43e62b9](43e62b9))
* only append `.api.grpc` suffix to group id if the artifact id starts
with `proto-` or `grpc-`
([#2731](#2731))
([8e87b2e](8e87b2e))
* opentelemetry-bom to be in third-party-dependencies BOM
([#2736](#2736))
([4ecc89b](4ecc89b))
* prepare to generate grafeas
([#2761](#2761))
([1114f18](1114f18))
* Replace deprecated protobuf methods.
([#2764](#2764))
([986c090](986c090))


### Dependencies

* update dependency black to v24.4.2
([#2660](#2660))
([1cbb681](1cbb681))
* update dependency com.fasterxml.jackson:jackson-bom to v2.17.1
([#2732](#2732))
([891b01d](891b01d))
* update dependency com.google.cloud:grpc-gcp to v1.6.0
([#2767](#2767))
([a39aa07](a39aa07))
* update dependency com.google.errorprone:error_prone_annotations to
v2.27.1
([#2708](#2708))
([4d7d246](4d7d246))
* update dependency com.google.errorprone:error_prone_annotations to
v2.27.1
([#2709](#2709))
([4e31d7d](4e31d7d))
* update dependency com.google.oauth-client:google-oauth-client-bom to
v1.36.0
([#2768](#2768))
([22b7398](22b7398))
* update dependency commons-codec:commons-codec to v1.17.0
([#2710](#2710))
([b87356c](b87356c))
* update dependency jinja2 to v3.1.4 [security]
([#2742](#2742))
([d67eaf8](d67eaf8))
* update dependency lxml to v5.2.2
([#2766](#2766))
([df7e211](df7e211))
* update dependency markupsafe to v2.1.5
([#2657](#2657))
([805baf8](805baf8))
* update dependency net.bytebuddy:byte-buddy to v1.14.15
([#2753](#2753))
([a472620](a472620))
* update dependency platformdirs to v4.2.1
([#2662](#2662))
([dbdcc91](dbdcc91))
* update googleapis/java-cloud-bom digest to db4265f
([#2755](#2755))
([908db6f](908db6f))
* update googleapis/java-cloud-bom digest to f3c611a
([#2700](#2700))
([d254e9b](d254e9b))
* update opentelemetry-java monorepo to v1.38.0
([#2769](#2769))
([0a5c7c4](0a5c7c4))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Joe Wang <106995533+JoeWang1127@users.noreply.github.com>
JoeWang1127 mentioned this pull request Jun 12, 2024
Closed
chingor13 pushed a commit to googleapis/google-cloud-java that referenced this pull request Mar 24, 2026
chore(main): release 2.40.1 (#2729)
5697127 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.40.1</summary>

##
[2.40.1](googleapis/sdk-platform-java@v2.40.0...v2.40.1)
(2024-05-15)


### Bug Fixes

* [common-protos] An existing method `UpdateVehicleLocation` is
([a8848b4](googleapis/sdk-platform-java@a8848b4))
* [common-protos] An existing method `UpdateVehicleLocation` is removed
from service `VehicleService`
([#2751](googleapis/sdk-platform-java#2751))
([a8848b4](googleapis/sdk-platform-java@a8848b4))
* [iam] An existing method `UpdateVehicleLocation` is removed from
([04ab176](googleapis/sdk-platform-java@04ab176))
* [iam] An existing method `UpdateVehicleLocation` is removed from
service `VehicleService`
([#2752](googleapis/sdk-platform-java#2752))
([04ab176](googleapis/sdk-platform-java@04ab176))
* do not populate repo level change while removing library
([#2740](googleapis/sdk-platform-java#2740))
([8d92d16](googleapis/sdk-platform-java@8d92d16))
* only append `.api.grpc` suffix to group id if the artifact id starts
with `proto-` or `grpc-`
([#2731](googleapis/sdk-platform-java#2731))
([b791c84](googleapis/sdk-platform-java@b791c84))
* opentelemetry-bom to be in third-party-dependencies BOM
([#2736](googleapis/sdk-platform-java#2736))
([0700180](googleapis/sdk-platform-java@0700180))
* prepare to generate grafeas
([#2761](googleapis/sdk-platform-java#2761))
([bf26ca1](googleapis/sdk-platform-java@bf26ca1))
* Replace deprecated protobuf methods.
([#2764](googleapis/sdk-platform-java#2764))
([c1e586d](googleapis/sdk-platform-java@c1e586d))


### Dependencies

* update dependency black to v24.4.2
([#2660](googleapis/sdk-platform-java#2660))
([027191f](googleapis/sdk-platform-java@027191f))
* update dependency com.fasterxml.jackson:jackson-bom to v2.17.1
([#2732](googleapis/sdk-platform-java#2732))
([3e94c74](googleapis/sdk-platform-java@3e94c74))
* update dependency com.google.cloud:grpc-gcp to v1.6.0
([#2767](googleapis/sdk-platform-java#2767))
([e360a3d](googleapis/sdk-platform-java@e360a3d))
* update dependency com.google.errorprone:error_prone_annotations to
v2.27.1
([#2708](googleapis/sdk-platform-java#2708))
([5ceb5fa](googleapis/sdk-platform-java@5ceb5fa))
* update dependency com.google.errorprone:error_prone_annotations to
v2.27.1
([#2709](googleapis/sdk-platform-java#2709))
([94df49f](googleapis/sdk-platform-java@94df49f))
* update dependency com.google.oauth-client:google-oauth-client-bom to
v1.36.0
([#2768](googleapis/sdk-platform-java#2768))
([f8500df](googleapis/sdk-platform-java@f8500df))
* update dependency commons-codec:commons-codec to v1.17.0
([#2710](googleapis/sdk-platform-java#2710))
([d1c14e9](googleapis/sdk-platform-java@d1c14e9))
* update dependency jinja2 to v3.1.4 [security]
([#2742](googleapis/sdk-platform-java#2742))
([e0ebded](googleapis/sdk-platform-java@e0ebded))
* update dependency lxml to v5.2.2
([#2766](googleapis/sdk-platform-java#2766))
([99e23f7](googleapis/sdk-platform-java@99e23f7))
* update dependency markupsafe to v2.1.5
([#2657](googleapis/sdk-platform-java#2657))
([834b258](googleapis/sdk-platform-java@834b258))
* update dependency net.bytebuddy:byte-buddy to v1.14.15
([#2753](googleapis/sdk-platform-java#2753))
([7494d67](googleapis/sdk-platform-java@7494d67))
* update dependency platformdirs to v4.2.1
([#2662](googleapis/sdk-platform-java#2662))
([9118e55](googleapis/sdk-platform-java@9118e55))
* update googleapis/java-cloud-bom digest to db4265f
([#2755](googleapis/sdk-platform-java#2755))
([afbbb78](googleapis/sdk-platform-java@afbbb78))
* update googleapis/java-cloud-bom digest to f3c611a
([#2700](googleapis/sdk-platform-java#2700))
([de5a108](googleapis/sdk-platform-java@de5a108))
* update opentelemetry-java monorepo to v1.38.0
([#2769](googleapis/sdk-platform-java#2769))
([74a2451](googleapis/sdk-platform-java@74a2451))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Joe Wang <106995533+JoeWang1127@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
meltsufin meltsufin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL