FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: add iam logging by JoeWang1127 · Pull Request #2932 · googleapis/sdk-platform-java · GitHub

This repository was archived by the owner on May 14, 2026. It is now read-only.

chore: add iam logging - #2932

Merged
JoeWang1127 merged 3 commits into
mainfrom
chore/add-iam-logging
Jun 20, 2024
Merged

chore: add iam logging#2932
JoeWang1127 merged 3 commits into
mainfrom
chore/add-iam-logging

Conversation

JoeWang1127 commented Jun 20, 2024
edited
Loading

Copy link
Copy Markdown
Contributor

In this PR:

  • Add logging module in google/iam/v1.
  • Regenerate iam.

product-auto-label Bot added the size: s Pull request size is small. label Jun 20, 2024
product-auto-label Bot added size: l Pull request size is large. and removed size: s Pull request size is small. labels Jun 20, 2024

Copy link
Copy Markdown

Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
45.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

JoeWang1127 marked this pull request as ready for review June 20, 2024 18:45
JoeWang1127 requested review from a team, blakeli0 and lqiu96 June 20, 2024 18:45

Copy link
Copy Markdown

Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

lqiu96 commented Jun 20, 2024
edited
Loading

Copy link
Copy Markdown
Member

Do you need to add in iam/logging to the proto_path for generation_config.yaml?

GAPICs:
- proto_path: google/iam/v1
- proto_path: google/iam/v2
- proto_path: google/iam/v2beta

Or is that only for protos with services/ GAPICs. Not too familiar with hermetic build, going to default to Blake's review.

lqiu96 removed their request for review June 20, 2024 18:50

Copy link
Copy Markdown
Contributor Author

Do you need to add in iam/logging to the proto_path for generation_config.yaml?

GAPICs:
- proto_path: google/iam/v1
- proto_path: google/iam/v2
- proto_path: google/iam/v2beta

Or is that only for protos with services/ GAPICs. Not too familiar with hermetic build, going to default to Blake's review.

No need to add a proto_path because logging is a nested directory in google/iam/v1 and all protos inside the proto_path should be generated by default.

I removed the special case in generate_library.sh so that this falls to the default case.

"client_documentation": "https://cloud.google.com/java/docs/reference/proto-google-iam-v1/latest/overview",
"release_level": "stable",
"transport": "grpc",
"transport": "both",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Do we know why the transport changed? Is it because this PR #2890?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, now iam/v2 is used to get the transport.

JoeWang1127 merged commit 122a493 into main Jun 20, 2024
JoeWang1127 deleted the chore/add-iam-logging branch June 20, 2024 22:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL