This repository was archived by the owner on May 14, 2026. It is now read-only.
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, something went wrong.
diegomarquezp
approved these changes
Mar 11, 2025
blakeli0
reviewed
Mar 11, 2025
Comment thread
hermetic_build/library_generation/cli/entry_point.py
| ) | ||
| @click.option( | ||
| "--api-definitions-path", | ||
| "--api-root", |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Since api-root is the same as api-definitions-path, can they call our scripts with api-definitions-path directly?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding alias to repository-path and api-definitions-path to be compatible with Librarian options
click options allows alias directly, so this change is trivial and does not affect any existing usage cases.