FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: make GPG signing conditional in PublishingConventionPlugin for local publishing by dkhawk · Pull Request #1743 · googlemaps/android-maps-utils · GitHub

/ android-maps-utils Public

build: make GPG signing conditional in PublishingConventionPlugin for local publishing #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkhawk wants to merge 1 commit into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 1 Commits 1 Checks 12 Files changed
Open

build: make GPG signing conditional in PublishingConventionPlugin for local publishing #1743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .kt  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
14 changes: 13 additions & 1 deletion build-logic/convention/src/main/kotlin/PublishingConventionPlugin.kt
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,19 @@ class PublishingConventionPlugin : Plugin<Project> {
)

publishToMavenCentral()
signAllPublications()

// Only enable GPG publication signing when signing credentials are present.
// Why: When signAllPublications() is invoked unconditionally, the Maven Publish plugin
// registers GPG signature files (.asc) as mandatory artifacts of the publication.
// On local developer machines without GPG keys configured, running tasks such as
// './gradlew publishToMavenLocal' fails because the .asc files cannot be generated.
// Making signing conditional allows local publishing to succeed without credentials
// while ensuring all CI and release pipeline builds are properly signed.
val isSigningConfigured = !providers.gradleProperty("signing.keyId").getOrElse("").isEmpty() ||
!providers.gradleProperty("signing.secretKeyRingFile").getOrElse("").isEmpty()
if (isSigningConfigured) {
signAllPublications()
}

val artifactIdName = when (project.name) {
"maps-utils" -> "android-maps-utils"
Expand Down
Back | FazBrowse Home | New Git URL