FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Geocode by place id by andyklimczak · Pull Request #427 · googlemaps/google-maps-services-python · GitHub

feat: Geocode by place id - #427

Merged
jpoehnelt merged 1 commit into
googlemaps:masterfrom
andyklimczak:geocode-place-id
Feb 2, 2022
Merged

feat: Geocode by place id#427
jpoehnelt merged 1 commit into
googlemaps:masterfrom
andyklimczak:geocode-place-id

Conversation

Copy link
Copy Markdown
Contributor

Geocode endpoint accepts a place_id param as an alternative to geocode
Google docs: https://developers.google.com/maps/documentation/geocoding/requests-places-geocoding

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

jpoehnelt self-requested a review February 2, 2022 20:44

Copy link
Copy Markdown

mind rebasing? i just fixed the tests in #428

Geocode endpoint accepts a `place_id` param as an alternative to geocode
Google docs: https://developers.google.com/maps/documentation/geocoding/requests-places-geocoding

Copy link
Copy Markdown
Contributor Author

Rebased and CLA signed

Copy link
Copy Markdown
Contributor Author

True closes #207

jpoehnelt merged commit 1364711 into googlemaps:master Feb 2, 2022

Copy link
Copy Markdown

Thanks!!!

googlemaps-bot pushed a commit that referenced this pull request Feb 2, 2022
# [4.6.0](v4.5.3...v4.6.0) (2022-02-02)

### Features

* Geocode by place id ([#427](#427)) ([1364711](1364711))

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 4.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Copy Markdown
Contributor Author

Thank you! Appreciate the quick response 🍕

andyklimczak deleted the geocode-place-id branch February 2, 2022 21:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL