FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Convert print statement to info log by sondrelg · Pull Request #455 · googlemaps/google-maps-services-python · GitHub

Convert print statement to info log - #455

Merged
amuramoto merged 1 commit into
googlemaps:masterfrom
sondrelg:master
Nov 21, 2022
Merged

Convert print statement to info log#455
amuramoto merged 1 commit into
googlemaps:masterfrom
sondrelg:master

Conversation

Copy link
Copy Markdown
Contributor

Closes #451

google-cla Bot commented Nov 17, 2022

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Copy Markdown
Member

@sondrelg Thanks for the PR! Please accept the CLA and I can merge

Copy link
Copy Markdown
Contributor Author

It's not letting me sign the CLA for my private e-mail.. Can I just say that I accept it here? I accept!

amuramoto merged commit 83ad827 into googlemaps:master Nov 21, 2022
googlemaps-bot pushed a commit that referenced this pull request Nov 21, 2022
## [4.7.1](v4.7.0...v4.7.1) (2022-11-21)

### Bug Fixes

* Convert print statement to info log ([#455](#455)) ([83ad827](83ad827))

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 4.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Copy Markdown

Hi all, this bit of the PR breaks the package:

-            print("\n","API queries_quota:", self.queries_quota,"\n")
+            logger.info("API queries_quota:", self.queries_quota)

A %s is needed in the message string, e.g. logger.info("API queries_quota: %s", self.queries_quota)

Could anyone tackle this? Cheers

Copy link
Copy Markdown
Contributor Author

I'm unavailable for the next few days unfortunately, but this seems like a 2 minute fix, so hopefully someone else can jump on it. Maybe you could open a PR @RemiCardona?

Copy link
Copy Markdown

@sondrelg sure thing, will do. Thanks for the quick response!

Copy link
Copy Markdown

@amuramoto Would you be able to take a look at this follow-up PR that corrects this log message from level INFO to DEBUG?
#479

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Print output in version 4.7.0

5 participants


Back | FazBrowse Home | New Git URL