FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add `editorial_summary` to atmosphere fields by jloffredo2 · Pull Request #472 · googlemaps/google-maps-services-python · GitHub

/ google-maps-services-python Public

feat: add editorial_summary to atmosphere fields - #472

Merged
wangela merged 3 commits into
googlemaps:masterfrom
jloffredo2:master
Jan 24, 2023
ConversationCommits (3)ChecksFiles changed
Merged

feat: add editorial_summary to atmosphere fields#472
wangela merged 3 commits into
googlemaps:masterfrom
jloffredo2:master

Conversation

jloffredo2 commented Jan 15, 2023

Copy link
Copy Markdown
Contributor

Fixes #471 🦕

google-cla Bot commented Jan 15, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

jloffredo2 commented Jan 15, 2023

Copy link
Copy Markdown
Contributor Author

CLA has been signed

wangela assigned wangela and unassigned amuramoto Jan 24, 2023
wangela self-requested a review January 24, 2023 08:53
wangela requested changes Jan 24, 2023
View reviewed changes

wangela left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for your pull request. Please make two changes:

  • revert the change to PLACES_FIND_FIELDS_ATMOSPHERE
  • add a semantic prefix feat: to your PR title to clear the Semantic PR check

and we'll be good to go.

Noting here that it would be inadvisable to add this field to tests/test_places.py since the editorial summary content might change.

Comment thread googlemaps/places.py Outdated
jloffredo2 changed the title Add editorial_summary to atmosphere fields feat: add editorial_summary to atmosphere fields Jan 24, 2023

jloffredo2 commented Jan 24, 2023

Copy link
Copy Markdown
Contributor Author

@wangela As per your request, I have reverted the change to PLACES_FIND_FIELDS_ATMOSPHERE and have added feat: to this PR title.

wangela approved these changes Jan 24, 2023
View reviewed changes

wangela left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for incorporating the feedback!

wangela merged commit 9f09ccb into googlemaps:master Jan 24, 2023
googlemaps-bot pushed a commit that referenced this pull request Jan 24, 2023
chore(release): 4.8.0 [skip ci]
65d5a26 
# [4.8.0](v4.7.3...v4.8.0) (2023-01-24)

### Features

* add `editorial_summary` to Place Details atmosphere fields ([#472](#472)) ([9f09ccb](9f09ccb))

googlemaps-bot commented Jan 24, 2023

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 4.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

wangela wangela approved these changes

Assignees

wangela

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add editorial_summary to place atmosphere field dictionary

4 participants

Back | FazBrowse Home | New Git URL