FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(places): correct typo in places detail fields by il-santo · Pull Request #504 · googlemaps/google-maps-services-python · GitHub

fix(places): correct typo in places detail fields - #504

Open
il-santo wants to merge 1 commit into
googlemaps:masterfrom
il-santo:master
Open

fix(places): correct typo in places detail fields#504
il-santo wants to merge 1 commit into
googlemaps:masterfrom
il-santo:master

Conversation

Copy link
Copy Markdown

Currently there is a typo in googlemaps/places.py that prevents the retrieval ot the address components array.

This commit fixes the above mentioned typo.

google-cla Bot commented Sep 28, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Copy Markdown
Author

CLA should pass. Why is it not doing it?

LLyaudet commented Jan 4, 2024

Copy link
Copy Markdown

Hello :),
It seems you have trouble to sign the CLA.
I don't see anything else that should prevent merging this PR.
I will upvote on the issue.
I also checked the documentation : https://developers.google.com/maps/documentation/places/web-service/reference/rest/v1/places?hl=en
It seems many other fields should be corrected :
adr_address corresponds to nothing apparently.
Best regards,
Laurent Lyaudet

il-santo closed this Jan 4, 2024
il-santo reopened this Jan 4, 2024

il-santo commented Jan 4, 2024

Copy link
Copy Markdown
Author

Hello :), It seems you have trouble to sign the CLA. I don't see anything else that should prevent merging this PR.

It simply doesn't work.

I signed the CLA several times, and it seems ok, but if I follow the procedure to rescan the PR as a first time contributor I get a 404.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL