feat: support for updating and deleting share access rule metadata - #3921
Open
simonostendorf wants to merge 1 commit into
Open
Conversation
- Implement UpdateMetadata and DeleteMetadatum functions in shareaccessrules. - Add corresponding test cases for metadata update and deletion. - Enhance GrantAccess to include metadata options. - Update related request and result structures to handle metadata.
winiciusallan
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good overall. I'd like to see how tests goes.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.