fix(FanoutCache): raise AttributeError so hasattr() works - #366
Open
ltsyk wants to merge 1 commit into
Open
ltsyk wants to merge 1 commit into
ltsyk wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
fix FanoutCache.__getattr__ to raise AttributeError for hasattr() (grantjenks#353)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FanoutCache.__getattr__ used assert for unknown attribute names. That raises AssertionError, which breaks Python's hasattr() (and tools like pympler / Django Debug Toolbar panels that probe attributes).
Change
Raise AttributeError for unknown attributes instead of asserting.
Test plan
Fixes #353