Preserve throttle tags when updating the token bucket - #381
Open
xiehuanyi wants to merge 1 commit into
Open
xiehuanyi wants to merge 1 commit into
xiehuanyi wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A throttled function loses its cache entry's tag on its first call. throttle(..., tag='limiters') initially stores that tag, but both token-bucket update paths overwrite the entry without it, so a subsequent cache.evict('limiters') leaves the limiter behind.
Keep the configured tag when updating the token bucket. The regression test covers consuming existing tokens and replenishing a full bucket, then confirms tag-based eviction still removes the entry.
Validation on Python 3.11.14: both new cases fail on unmodified master; the full test suite passes all 251 tests after the fix. Blue, Flake8, isort, Mypy, and Pylint 2.17.7 pass. Current Pylint reports pre-existing configuration/positional-argument diagnostics, so local lint validation used the compatible 2.x version. Other interpreter versions were not run locally.
Developed, reviewed, and tested with AI assistance.