FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: resolve gf-connect is not published by SemyonSinchenko · Pull Request #645 · graphframes/graphframes · GitHub

/ graphframes Public

fix: resolve gf-connect is not published - #645

Merged
SemyonSinchenko merged 11 commits into
graphframes:masterfrom
SemyonSinchenko:639-fix-connect-publishing
Jul 17, 2025
ConversationCommits (11)ChecksFiles changed
Merged

fix: resolve gf-connect is not published#645
SemyonSinchenko merged 11 commits into
graphframes:masterfrom
SemyonSinchenko:639-fix-connect-publishing

Conversation

SemyonSinchenko commented Jul 17, 2025

Copy link
Copy Markdown
Collaborator

What changes were proposed in this pull request?

Refactoring according the comment

Why are the changes needed?

Close #639

SemyonSinchenko changed the title 639 fix connect publishing fix: resolve gf-connect is not published Jul 17, 2025
SemyonSinchenko self-assigned this Jul 17, 2025

SemyonSinchenko commented Jul 17, 2025

Copy link
Copy Markdown
Collaborator Author

Thanks @Kimahriman for the suggestion! I tried publishLocal and it works as expected!

Kimahriman reviewed Jul 17, 2025
View reviewed changes
Comment thread .github/workflows/scala-ci.yml Outdated
Kimahriman reviewed Jul 17, 2025
View reviewed changes
Comment thread .github/workflows/scala-ci.yml Outdated

Kimahriman commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

IMO it would be cleaner to just have core/ and connect/ folders, instead of having both prefixed with graphframes-, but up to you

SemyonSinchenko and others added 2 commits July 17, 2025 18:05
Update .github/workflows/scala-ci.yml
07fa477 
Co-authored-by: Adam Binford <adamq43@gmail.com>
Update .github/workflows/scala-ci.yml
2edf3b9 
Co-authored-by: Adam Binford <adamq43@gmail.com>
Kimahriman reviewed Jul 17, 2025
View reviewed changes
Comment thread .github/workflows/scala-ci.yml Outdated

Kimahriman commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

One last other thing I noticed. The Spark 3 build is built with Java 11, but Spark 3 does support Java 8 so the released artifacts should be built with Java 8

Update .github/workflows/scala-ci.yml
6fff061 
Co-authored-by: Adam Binford <adamq43@gmail.com>

SemyonSinchenko commented Jul 17, 2025

Copy link
Copy Markdown
Collaborator Author

And again thanks a lot @Kimahriman ! Your experience is helping a lot to GraphFarmes to become better!!

SemyonSinchenko commented Jul 17, 2025

Copy link
Copy Markdown
Collaborator Author

I will update

rjurney approved these changes Jul 17, 2025
View reviewed changes

rjurney left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm, looks like core got left out previously?

rjurney commented Jul 17, 2025

Copy link
Copy Markdown
Collaborator

Oh wait, CI failed...

Kimahriman reviewed Jul 17, 2025
View reviewed changes
Comment thread .github/workflows/scala-ci.yml Outdated
Update .github/workflows/scala-ci.yml
391b596 
Co-authored-by: Adam Binford <adamq43@gmail.com>

SemyonSinchenko commented Jul 17, 2025

Copy link
Copy Markdown
Collaborator Author

lgtm, looks like core got left out previously?

@Kimahriman resolved the puzzle (see comments in the issue). Mostly it was my fault, I was needed to refactor it to the right multi-project sbt layout when I introduced connect.

SemyonSinchenko merged commit 7c5ae09 into graphframes:master Jul 17, 2025
SemyonSinchenko deleted the 639-fix-connect-publishing branch July 17, 2025 19:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rjurney rjurney approved these changes
james-willis Awaiting requested review from james-willis
+1 more reviewer
Kimahriman Kimahriman left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

SemyonSinchenko

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: graphframes-connect is not published

3 participants

Back | FazBrowse Home | New Git URL