ci: add codespell spell check and extend python linting to dev scripts - #864
Merged
james-willis merged 3 commits intoJun 16, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
james-willis
marked this pull request as ready for review
June 16, 2026 18:09
- Add codespell (config in .codespellrc) covering yml, python and scala via a new Spell Check workflow and a pre-commit hook; fix the typos it surfaced across sources and docs. graphx/ is excluded to stay aligned with upstream Apache Spark. - Extend black/flake8/isort to the dev/ and python/dev/ scripts in both the Python CI code-style step and pre-commit.
…iscovery When ../dev is included, black/isort resolve their config from the common parent of all paths (the repo root, which has no pyproject.toml) and fall back to defaults. Pass --config/--settings-path explicitly.
james-willis
force-pushed
the
ci/spellcheck-and-dev-linting
branch
from
4323a68 to
78f5066
Compare
June 16, 2026 21:37
SemyonSinchenko
approved these changes
Jun 16, 2026
run_connect.py and stop_connect.py were added in graphframes#863 before the linting scope was extended to dev/. Apply black/isort and add a noqa for an unavoidable long config string so python-ci passes.
Copy link
Copy Markdown
|
⚠️ Please install the Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #864 +/- ##
=======================================
Coverage 81.63% 81.63%
=======================================
Files 81 81
Lines 4682 4682
Branches 574 574
=======================================
Hits 3822 3822
Misses 860 860 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Some CI improvements. spell check + more linter coverage for CI scripts
Why are the changes needed?
Keeps our docs and source code typo free + well formated. improves maintainability and professionalism. Reduces review churn