| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Co-authored-by: rjurney <42149+rjurney@users.noreply.github.com>
There was a problem hiding this comment.
Please revert the change to pyproject.toml
Sorry, something went wrong.
| "Code Repository" = "https://github.com/graphframes/graphframes" | ||
| "Bug Tracker" = "https://github.com/graphframes/graphframes/issues" | ||
|
|
||
| [tool.poetry.dependencies] |
There was a problem hiding this comment.
Why did you move this here? I think it belongs under tutorials, since it is required for the CLI. I don't want a separate dependency group of one package.
Sorry, something went wrong.
There was a problem hiding this comment.
Reverted — click is back under [tool.poetry.group.tutorials.dependencies] only. The [tool.poetry.dependencies] section has been removed.
Sorry, something went wrong.
Co-authored-by: rjurney <42149+rjurney@users.noreply.github.com>
Reverted in 524c053~1 — pyproject.toml is back to its original state with click under [tool.poetry.group.tutorials.dependencies]. The only remaining change is the lazy-import of graphframes.tutorials.download inside main() in console.py. |
Sorry, something went wrong.
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
console.py imported click at module level, but click was only declared under the tutorials optional group. A plain pip install graphframes-py would install the graphframes console script that immediately fails with ModuleNotFoundError: click.
What changes were proposed in this pull request?
Why are the changes needed?
The graphframes console script is always installed via [tool.poetry.scripts], so click must be a core dependency, not an optional one. Lazy-importing the tutorials module avoids pulling in heavy optional deps (py7zr, requests) for users who haven't installed the tutorials extra.