FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

make NodeTraverser public and improves it with preOder/postOrder methods by andimarek · Pull Request #1097 · graphql-java/graphql-java · GitHub

/ graphql-java Public

make NodeTraverser public and improves it with preOder/postOrder methods - #1097

Merged
andimarek merged 2 commits into
masterfrom
node-traverser
Jul 4, 2018
ConversationCommits (2)ChecksFiles changed
Merged

make NodeTraverser public and improves it with preOder/postOrder methods#1097
andimarek merged 2 commits into
masterfrom
node-traverser

Conversation

andimarek commented Jun 23, 2018

Copy link
Copy Markdown
Member

graphql-java should provide a good way to traverse a Document/Query. This makes the NodeTraverser public and adds special pre/post Order methods for easy usage.

andimarek requested a review from bbakerman June 23, 2018 09:29

andimarek commented Jun 23, 2018

Copy link
Copy Markdown
Member Author

This includes making some parts of the general Traverser public, but not everything.

andimarek mentioned this pull request Jun 23, 2018
Merged

andimarek commented Jun 23, 2018

Copy link
Copy Markdown
Member Author

@bbakerman @gkesler @exbe I would like to link to some good explanation about general traversal and for example pre/post order is a special case of depthFirst. Any recommendations? thx

bbakerman approved these changes Jun 24, 2018
View reviewed changes

bbakerman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me - nothing stands out as a problem

bbakerman added this to the 10.0 milestone Jun 25, 2018

exbe commented Jun 25, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

@andimarek Are you looking for an example, explanation or something else?

Updated: I think it make sense to add similar special cases for breadthFirst too as a legitimate api.

andimarek merged commit 795c232 into master Jul 4, 2018
andimarek deleted the node-traverser branch July 12, 2018 11:27
exbe pushed a commit to intuit/graphql-java that referenced this pull request Jul 27, 2018
Make TypeTraverser public with respect to graphql-java#1097
126f3df
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bbakerman bbakerman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

9.1

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL