Alternative fix to dead lock challenge - #1255
Merged
bbakerman merged 18 commits intoOct 3, 2018
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This reverts commit 38dfab1
Copy link
Copy Markdown
Member
Author
|
I was able to replicate 100% of the time without the change as per @tinnou original test |
Sorry, something went wrong.
andimarek
reviewed
Oct 2, 2018
Comment thread
src/main/java/graphql/execution/instrumentation/dataloader/FieldLevelTrackingApproach.java
| public void dispatchIfNotDispatchedBefore(int level, Runnable dispatch) { | ||
| public boolean dispatchIfNotDispatchedBefore(int level) { | ||
| if (dispatchedLevels.contains(level)) { | ||
| Assert.assertShouldNeverHappen("level " + level + " already dispatched"); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
you could actually return the Assert
Sorry, something went wrong.
bbakerman
added a commit
to bbakerman/graphql-java
that referenced
this pull request
Oct 3, 2018
* Added @OverRide as part of errorprone code health check * Revert "Added @OverRide as part of errorprone code health check" This reverts commit 38dfab1 * Brads attempt at graphql-java#1234 * Missed the test
Merged
bbakerman
added a commit
that referenced
this pull request
Oct 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1234
This is similar but more deliberate. That is we work out IF we have to dispatch inside the lock and then do the dispatch outside it.
I think this is a smidge cleaner than the other PR. (but the same effect)