Add support for visiting fragment definitions in QueryVisitor. - #1445
Merged
andimarek merged 5 commits intoMar 11, 2019
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
bbakerman
approved these changes
Mar 7, 2019
bbakerman
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice one
Sorry, something went wrong.
andimarek
requested changes
Mar 10, 2019
andimarek
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
nice ... see my comments about naming
Sorry, something went wrong.
Comment thread
src/main/java/graphql/analysis/QueryVisitor.java
Outdated
Comment thread
src/main/java/graphql/analysis/QueryVisitorFragmentEnvironment.java
Outdated
Comment thread
src/main/java/graphql/analysis/QueryVisitorFragmentEnvironmentImpl.java
Outdated
Copy link
Copy Markdown
Author
Renamed as per your comments and added #toString |
Sorry, something went wrong.
andimarek
requested changes
Mar 11, 2019
andimarek
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
typo ... otherwise ready to be merged
Sorry, something went wrong.
Comment thread
src/test/groovy/graphql/analysis/QueryTraversalTest.groovy
Outdated
| import static java.util.Collections.emptyMap | ||
|
|
||
| class QueryTraversalTest extends Specification { | ||
| class QueryTrqaversalTest extends Specification { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
typo :-)
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.