LambdaMetafactory support for property fetches - #2985
Merged
bbakerman merged 6 commits intoOct 31, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Another PR on improving getter access
Copy link
Copy Markdown
Member
|
@bbakerman I think is worth to also benchmark on JDK 17. |
Sorry, something went wrong.
Fixed test where parameters are present
Benchmark fix up
Copy link
Copy Markdown
Member
Author
|
JDK 17 Benchmark Mode Cnt Score Error Units GetterAccessBenchmark.measureDirectAccess thrpt 15 458411420.717 ± 34329506.990 ops/s 0% GetterAccessBenchmark.measureLambdaAccess thrpt 15 334158880.091 ± 10666070.698 ops/s 27% slower GetterAccessBenchmark.measureReflectionAccess thrpt 15 63181868.566 ± 3887367.970 ops/s 86% slower |
Sorry, something went wrong.
arlampin
reviewed
Oct 17, 2022
Comment thread
src/main/java/graphql/schema/PropertyFetchingImpl.java
Outdated
| } | ||
|
|
||
| private static class CachedFunction { | ||
| Function<Object, Object> getter; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I remember reading that declaring fields final might improve method reference performance so it might apply here. Although maybe it was just static final constants.
Sorry, something went wrong.
dondonz
reviewed
Oct 29, 2022
Comment thread
src/main/java/graphql/schema/fetching/LambdaFetchingSupport.java
Outdated
| Function<Object, Object> getterFunction = mkCallFunction(sourceClass, candidateMethod.getName(), candidateMethod.getReturnType()); | ||
| return Optional.of(getterFunction); | ||
| } catch (Throwable ignore) { | ||
| // if we can make a dynamic lambda here, then we give up and let the old property fetching code do its thing |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| // if we can make a dynamic lambda here, then we give up and let the old property fetching code do its thing | |
| // if we can't make a dynamic lambda here, then we give up and let the old property fetching code do its thing |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another PR on improving getter access. Thanks to @arlampin for the inspiration.
https://wttech.blog/blog/2020/method-handles-and-lambda-metafactory/
https://www.optaplanner.org/blog/2018/01/09/JavaReflectionButMuchFaster.html
Early benchmarks on direct access versus lambda access versus the reflection method access we have today
JDK 1.8.0_191, Java HotSpot(TM) 64-Bit Server VM, 25.191-b12 - Mac M1