FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

JS like Batching by andimarek · Pull Request #3873 · graphql-java/graphql-java · GitHub

/ graphql-java Public

JS like Batching - #3873

Closed
andimarek wants to merge 3 commits into
masterfrom
dataloader-cfs-only-window-batching
ConversationCommits (3)ChecksFiles changed
Closed

JS like Batching#3873
andimarek wants to merge 3 commits into
masterfrom
dataloader-cfs-only-window-batching

Conversation

andimarek commented Mar 30, 2025

Copy link
Copy Markdown
Member

This is a modified version of #3872

Probably the closest Java can get to the JS dataloader batching:

  • we track now if the engine is running in the ExecutionContext (regardless of thread)
  • a very small batch window of 0.1ms is started every time a new DataLoaderCF is created.
  • if the DatatLoaderCF encounters a running engine while trying to dispatch the time window resets to avoid dispatching while the engine is running

github-actions Bot commented Mar 30, 2025

Copy link
Copy Markdown
Contributor

Test Results

  312 files    312 suites   51s ⏱️
3 580 tests 3 573 ✅ 6 💤 1 ❌
3 669 runs  3 662 ✅ 6 💤 1 ❌

For more details on these failures, see this check.

Results for commit dc19532.

andimarek closed this Apr 1, 2025
dondonz removed this from the 25.x breaking changes milestone Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL