Add JSpecify nullability annotations to DataFetcherResult - #3891
Merged
dondonz merged 1 commit intoApr 8, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Test Results 313 files 313 suites 50s ⏱️ Results for commit f962466. |
Sorry, something went wrong.
andimarek
approved these changes
Apr 5, 2025
andimarek
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Exactly what we should do incrementally.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a classic NPE mistake because I forgot to check if data was null while writing a DataFetcher
With JSpecify, we can detect NPEs like this at compile time rather than run time.
Have a look at the documentation for @NullMarked https://jspecify.dev/docs/user-guide/#nullmarked
This is the first PR to add JSpecify to an existing class so let's have a discussion.