Fix and improve EngineRunning state - #3911
Merged
bbakerman merged 1 commit intoApr 14, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
fixes cases where the CF<ER> is finished before the observer is called for the last time
Copy link
Copy Markdown
Contributor
Test Results 313 files 313 suites 53s ⏱️ Results for commit 71c8032. |
Sorry, something went wrong.
bbakerman
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the engine state updates are side effects, it can happen that the last "NOT_RUNNING" happens after the overall CompletableFuture<ExecutionResult> is completed.
As this is very counterintuitive this PR fixes that edge case with observing the CompletableFuture<ExecutionResult> explicitly.
It also make explicit states for Start and finish the engine.