This removes the FetchedValue wrapping by default - #3924
Merged
dondonz merged 11 commits intoJul 10, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Test Results 323 files 323 suites 3m 2s ⏱️ Results for commit 095ba62. ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Manually run JMH tests This branch Benchmark Mode Cnt Score Error Units LargeInMemoryQueryPerformance.benchMarkSimpleQueriesThroughput thrpt 4 0.247 ± 0.038 ops/s # better LargeInMemoryQueryPerformance.benchMarkSimpleQueriesThroughput:gc.alloc.rate thrpt 4 4076.203 ± 258.101 MB/sec # better LargeInMemoryQueryPerformance.benchMarkSimpleQueriesThroughput:gc.alloc.rate.norm thrpt 4 17320751492.000 ± 2385254881.326 B/op # slightly better LargeInMemoryQueryPerformance.benchMarkSimpleQueriesThroughput:gc.count thrpt 4 69.000 counts # same LargeInMemoryQueryPerformance.benchMarkSimpleQueriesThroughput:gc.time thrpt 4 11174.000 ms # better LargeInMemoryQueryPerformance.benchMarkSimpleQueriesAvgTime avgt 4 4.228 ± 1.047 s/op # worse LargeInMemoryQueryPerformance.benchMarkSimpleQueriesAvgTime:gc.alloc.rate avgt 4 4019.164 ± 992.876 MB/sec # better LargeInMemoryQueryPerformance.benchMarkSimpleQueriesAvgTime:gc.alloc.rate.norm avgt 4 17800984633.333 ± 7488957.877 B/op # better LargeInMemoryQueryPerformance.benchMarkSimpleQueriesAvgTime:gc.count avgt 4 80.000 counts # worse LargeInMemoryQueryPerformance.benchMarkSimpleQueriesAvgTime:gc.time avgt 4 11929.000 ms # worse master Benchmark Mode Cnt Score Error Units LargeInMemoryQueryPerformance.benchMarkSimpleQueriesThroughput thrpt 4 0.260 ± 0.049 ops/s LargeInMemoryQueryPerformance.benchMarkSimpleQueriesThroughput:gc.alloc.rate thrpt 4 4382.516 ± 694.460 MB/sec LargeInMemoryQueryPerformance.benchMarkSimpleQueriesThroughput:gc.alloc.rate.norm thrpt 4 17680353848.000 ± 1492524470.152 B/op LargeInMemoryQueryPerformance.benchMarkSimpleQueriesThroughput:gc.count thrpt 4 72.000 counts LargeInMemoryQueryPerformance.benchMarkSimpleQueriesThroughput:gc.time thrpt 4 8996.000 ms LargeInMemoryQueryPerformance.benchMarkSimpleQueriesAvgTime avgt 4 3.904 ± 1.378 s/op LargeInMemoryQueryPerformance.benchMarkSimpleQueriesAvgTime:gc.alloc.rate avgt 4 4439.397 ± 1687.989 MB/sec LargeInMemoryQueryPerformance.benchMarkSimpleQueriesAvgTime:gc.alloc.rate.norm avgt 4 18133700842.667 ± 2305552942.125 B/op LargeInMemoryQueryPerformance.benchMarkSimpleQueriesAvgTime:gc.count avgt 4 70.000 counts LargeInMemoryQueryPerformance.benchMarkSimpleQueriesAvgTime:gc.time avgt 4 9392.000 ms It definitely helped in using less memory. Interestingly the gc.time went up - not sure how to read that |
Sorry, something went wrong.
…wrapping # Conflicts: # src/main/java/graphql/execution/ExecutionStrategy.java # src/main/java/graphql/execution/SubscriptionExecutionStrategy.java
bbakerman
commented
Jul 8, 2025
Comment thread
...ava/graphql/execution/instrumentation/parameters/InstrumentationFieldCompleteParameters.java
| * | ||
| * @return the object was fetched, ready to be completed as a value. | ||
| */ | ||
| public Object getFetchedObject() { |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
This is the hard breaking change - the new method means they HAVE to handle it should they be using the old method
Sorry, something went wrong.
bbakerman
commented
Jul 8, 2025
| if (parameters.fetchedValue instanceof FetchedValue) { | ||
| FetchedValue value = (FetchedValue) parameters.fetchedValue | ||
| if (parameters.getFetchedObject() instanceof FetchedValue) { | ||
| FetchedValue value = (FetchedValue) parameters.getFetchedObject() |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
example of hard break!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #3922
This removes FetchedValue wrapping of every value we get back from a DataFetcher
This only wraps it in a FetchedValue if the DF returned the complex graphql.execution.DataFetcherResult.
The consuming code now needs to tests if its a FetchedValue to get its underlying value or to use it direct