ExecutionStrategyParameters now has a direct transform without a Builder - #3935
Merged
dondonz merged 2 commits intoMay 14, 2025
Merged
ExecutionStrategyParameters now has a direct transform without a Builder#3935dondonz merged 2 commits into
dondonz merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
bbakerman
commented
Apr 28, 2025
|
|
||
| Object resolveSerialField = resolveSerialField(executionContext, dataLoaderDispatcherStrategy, newParameters); | ||
| return resolveSerialField; | ||
| return resolveSerialField(executionContext, dataLoaderDispatcherStrategy, newParameters); |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
inlined variable
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Test Results 312 files 312 suites 55s ⏱️ Results for commit 3790a10. |
Sorry, something went wrong.
dondonz
reviewed
May 14, 2025
| return currentField; | ||
| } | ||
|
|
||
| @Internal |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Good that it's Internal
Sorry, something went wrong.
dondonz
approved these changes
May 14, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is really 1% stuff. Its debatably faster BUT it uses (slightly) less memory and thats a good thing at scale