A generalised configuration mechanism - #3945
Conversation
Sorry, something went wrong.
| * including some JVM wide settings and some per execution settings | ||
| * as well as experimental ones | ||
| */ | ||
| public class GraphQLConfiguration { |
There was a problem hiding this comment.
Other name suggestion GraphQlSettings and hence the name of GraphQl.configuration() would change
Sorry, something went wrong.
| * This static can be set to true to allow the behavior of version 16.x or before. | ||
| * | ||
| * @param options - the new default JVM parser options for operation parsing | ||
| * @param options - the new default JVM parser options for SDL parsing |
There was a problem hiding this comment.
found a java doc mistake
Sorry, something went wrong.
Test Results 316 files 316 suites 2m 26s ⏱️ Results for commit 3c5c911. ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
| return INCREMENTAL_SUPPORT_CFG; | ||
| } | ||
|
|
||
| public static class ParserCfg { |
There was a problem hiding this comment.
parse config here is repeated - so sure you can go direct to ParserOptions and thats not too bad a name to discover
BUT
This makes it central and future ones can be here
Sorry, something went wrong.
…ntext wrapping mechanism
…ntext wrapping mechanism - renamed as extraordinary
…ntext wrapping mechanism - renamed as unusual
…ntext wrapping mechanism - renamed as config
Discoverability of how to config special parts of graphql-java is low
This tries to centralise that by providing a simple DSL and a common place to set both JVM wide and execution specific configuration
This is currently
def builder = GraphQLContext.newContext() GraphQL.configuration().incrementalSupport().enableIncrementalSupport(builder, true)but it could be
def builder = GraphQLContext.newContext() GraphQL.configuration.incrementalSupport.enableIncrementalSupport(builder, true)or
but I kinda like how it comes off the GraphQl object for discoverability