Avoid rare TCK test failure - #3975
Merged
andimarek merged 1 commit intoMay 16, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…ad locals to track things, which can cause tests failure in rare cases
bbakerman
approved these changes
May 16, 2025
Copy link
Copy Markdown
Contributor
Test Results 315 files ±0 315 suites ±0 2m 27s ⏱️ +2s Results for commit dcb9b05. ± Comparison against base commit c16cf96. This pull request removes 150 and adds 128 tests. Note that renamed tests count towards both. ?
__schema { types { fields { args { type { name fields { name }}}}}}
__schema { types { fields { type { name fields { name }}}}}
__schema { types { inputFields { type { inputFields { name }}}}}
__schema { types { interfaces { fields { type { interfaces { name } } } } } }
__schema { types { name} }
__type(name : "t") { name }
a1: __schema { types { name} }
a1: __type(name : "t") { name }
a2 : __type(name : "t1") { name }
…
graphql.ScalarsBooleanTest ‑ parseValue throws exception for invalid input <java.lang.Object@525eac20> graphql.ScalarsBooleanTest ‑ serialize throws exception for invalid input <java.lang.Object@51e722fc> graphql.ScalarsIDTest ‑ parseValue allows any object via String.valueOf <java.lang.Object@79e72fac> graphql.ScalarsIDTest ‑ serialize allows any object via String.valueOf <java.lang.Object@24c67fda> graphql.ScalarsIntTest ‑ parseValue throws exception for invalid input <java.lang.Object@51476b96> graphql.ScalarsIntTest ‑ serialize throws exception for invalid input <java.lang.Object@60d22fce> graphql.execution.instrumentation.TracingInstrumentationTest ‑ do not trace introspection information [testExecutionStrategy: <graphql.execution.AsyncExecutionStrategy@d763063 fieldCollector=graphql.execution.FieldCollector@4debf7c4 executionStepInfoFactory=graphql.execution.ExecutionStepInfoFactory@34b3fc15 dataFetcherExceptionHandler=graphql.execution.SimpleDataFetcherExceptionHandler@75096f5c resolvedType=graphql.execution.ResolveType@49c0bcb6>, #0] graphql.execution.instrumentation.TracingInstrumentationTest ‑ do not trace introspection information [testExecutionStrategy: <graphql.execution.AsyncSerialExecutionStrategy@707f2bbc fieldCollector=graphql.execution.FieldCollector@4e32c960 executionStepInfoFactory=graphql.execution.ExecutionStepInfoFactory@25bf91c dataFetcherExceptionHandler=graphql.execution.SimpleDataFetcherExceptionHandler@60028d15 resolvedType=graphql.execution.ResolveType@69296862>, #1] graphql.execution.instrumentation.TracingInstrumentationTest ‑ tracing captures timings as expected [testExecutionStrategy: <graphql.execution.AsyncExecutionStrategy@406570d2 fieldCollector=graphql.execution.FieldCollector@6e58b55 executionStepInfoFactory=graphql.execution.ExecutionStepInfoFactory@60881be8 dataFetcherExceptionHandler=graphql.execution.SimpleDataFetcherExceptionHandler@31b78ac5 resolvedType=graphql.execution.ResolveType@5a3f9fc1>, #0] graphql.execution.instrumentation.TracingInstrumentationTest ‑ tracing captures timings as expected [testExecutionStrategy: <graphql.execution.AsyncSerialExecutionStrategy@61cd05ab fieldCollector=graphql.execution.FieldCollector@233d6218 executionStepInfoFactory=graphql.execution.ExecutionStepInfoFactory@2c560bf1 dataFetcherExceptionHandler=graphql.execution.SimpleDataFetcherExceptionHandler@2192ffe8 resolvedType=graphql.execution.ResolveType@287b562c>, #1] … |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use always a new thread for the tck verification as the TCK uses thread locals to track things, which can cause tests failure in rare cases