Add ArchUnit rule to ban javax & JetBrains nullability annotations - #3985
Add ArchUnit rule to ban javax & JetBrains nullability annotations#3985dondonz merged 2 commits into
Conversation
Sorry, something went wrong.
| -exportcontents: graphql.* | ||
| -removeheaders: Private-Package | ||
| Import-Package: !android.os.*,!com.google.*,!org.checkerframework.*,!javax.annotation.*,!graphql.com.google.*,!org.antlr.*,!graphql.org.antlr.*,!sun.misc.*,org.jspecify.annotations;resolution:=optional,* | ||
| Import-Package: !android.os.*,!com.google.*,!org.checkerframework.*,!graphql.com.google.*,!org.antlr.*,!graphql.org.antlr.*,!sun.misc.*,org.jspecify.annotations;resolution:=optional,* |
There was a problem hiding this comment.
While I'm here, we can clean up our config to remove javax.annotation
Sorry, something went wrong.
Test Results 317 files 317 suites 2m 28s ⏱️ Results for commit 08c8bd3. |
Sorry, something went wrong.
|
We also need to add this to gradle itself, right? Or am I missing something here? |
Sorry, something went wrong.
This runs as a standard test. If there's a violation, it'll turn up in our usual build as a failing test Or did you mean about adding ArchUnit as a dependency? It was already added in another PR that added a rule |
Sorry, something went wrong.
Going forward we will be using JSpecify Nullability annotations.
It's possible to accidentally pull in the old javax Nullability annotations because this doesn't need any changes to our build.gradle dependencies.
While it's unlikely someone would accidentally add JetBrains Nullability annotations, because these require a new dependency to be added, I have also banned them.
Sample test output when a banned usage is found: