New Exhaustion based data loader dispatching strategy - #4130
Merged
andimarek merged 17 commits intoSep 28, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Test Results 325 files 325 suites 5m 7s ⏱️ Results for commit 6c9d267. ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
bbakerman
reviewed
Sep 29, 2025
|
|
||
| } | ||
|
|
||
| default void startComplete(ExecutionStrategyParameters parameters) { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
javadoc would be nice
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an alternative data loader strategy that mimics in some way how the JS event loop Data Loader dispatcher works:
Instead of dispatching per Level (the current default) this strategy dispatches as soon as the engine is not "busy" anymore.
Busy here means specifically:
This also handles "chained data loaders": data loaders being used after another data loader inside one DataFetcher.
This new dispatching strategy can be enabled by setting
or