Add documentation and test for additionalTypes in GraphQLSchema - #4208
Merged
andimarek merged 2 commits intoJan 19, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
- Add comprehensive JavaDoc to getAdditionalTypes() explaining when additional types are needed (interface implementations, SDL schemas, programmatic schemas with type references) - Add JavaDoc to builder methods additionalTypes(), additionalType(), and clearAdditionalTypes() - Document that there are no restrictions on what types can be added - Add test demonstrating that additionalTypes accepts any type, including types already reachable from root operations - Add .vscode to .gitignore
Copy link
Copy Markdown
Contributor
Test Results 327 files ±0 327 suites ±0 5m 12s ⏱️ -5s Results for commit c4fc1d0. ± Comparison against base commit 7fb2729. This pull request removes 213 and adds 190 tests. Note that renamed tests count towards both. ?
, expected: combo-\"\\\b\f\n\r\t, #4]
__schema { types { fields { args { type { name fields { name }}}}}}
__schema { types { fields { type { name fields { name }}}}}
__schema { types { inputFields { type { inputFields { name }}}}}
__schema { types { interfaces { fields { type { interfaces { name } } } } } }
__schema { types { name} }
__type(name : "t") { name }
a1: __schema { types { name} }
a1: __type(name : "t") { name }
…
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure23@255eaa6b delegate=graphql.AssertTest@36a6bea6 owner=graphql.AssertTest@36a6bea6 thisObject=graphql.AssertTest@36a6bea6 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0] graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure24@476fe690 delegate=graphql.AssertTest@36a6bea6 owner=graphql.AssertTest@36a6bea6 thisObject=graphql.AssertTest@36a6bea6 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1] graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure25@7a0e7ecd delegate=graphql.AssertTest@36a6bea6 owner=graphql.AssertTest@36a6bea6 thisObject=graphql.AssertTest@36a6bea6 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2] graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure20@21bd20ee delegate=graphql.AssertTest@36a6bea6 owner=graphql.AssertTest@36a6bea6 thisObject=graphql.AssertTest@36a6bea6 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0] graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure21@26c47874 delegate=graphql.AssertTest@36a6bea6 owner=graphql.AssertTest@36a6bea6 thisObject=graphql.AssertTest@36a6bea6 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1] graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure22@421056e5 delegate=graphql.AssertTest@36a6bea6 owner=graphql.AssertTest@36a6bea6 thisObject=graphql.AssertTest@36a6bea6 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2] graphql.AssertTest ‑ assertNotNull with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure3@35267fd4 delegate=graphql.AssertTest@36a6bea6 owner=graphql.AssertTest@36a6bea6 thisObject=graphql.AssertTest@36a6bea6 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0] graphql.AssertTest ‑ assertNotNull with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure4@711d1a52 delegate=graphql.AssertTest@36a6bea6 owner=graphql.AssertTest@36a6bea6 thisObject=graphql.AssertTest@36a6bea6 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1] graphql.AssertTest ‑ assertNotNull with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure5@67c5ac52 delegate=graphql.AssertTest@36a6bea6 owner=graphql.AssertTest@36a6bea6 thisObject=graphql.AssertTest@36a6bea6 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2] graphql.AssertTest ‑ assertNotNull with different number of error args with non null does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_6prov0_closure6@7899de11 delegate=graphql.AssertTest@36a6bea6 owner=graphql.AssertTest@36a6bea6 thisObject=graphql.AssertTest@36a6bea6 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0] … ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
bbakerman
approved these changes
Jan 19, 2026
bbakerman
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Excellent
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify additional types purpose.