[DO NOT MERGE] Schema traverser perf - #4232
Closed
andimarek wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Adds benchmark to compare built-in SchemaTraverser.depthFirstFullSchema() with manual recursive traversal using direct iteration over schema.getAllTypesAsList(). Results show manual traversal is ~13x faster for steady-state and ~3.5x faster for cold-start, while counting the same 5030 schema elements. - SchemaTraversalBenchmark: JMH benchmark with both approaches - SchemaTraversalVerificationTest: Verifies both count identical elements - build.gradle: Add JMH include filter configuration Co-authored-by: Cursor <cursoragent@cursor.com>
Enable passing profilers via -Pjmh.profilers (e.g., 'gc' for memory profiling). Co-authored-by: Cursor <cursoragent@cursor.com>
Copy link
Copy Markdown
Contributor
Test Results 328 files +1 328 suites +1 5m 8s ⏱️ -2s Results for commit 81fb886. ± Comparison against base commit 7ba1647. This pull request removes 196 and adds 173 tests. Note that renamed tests count towards both. ?
, expected: combo-\"\\\b\f\n\r\t, #4]
__schema { types { fields { args { type { name fields { name }}}}}}
__schema { types { fields { type { name fields { name }}}}}
__schema { types { inputFields { type { inputFields { name }}}}}
__schema { types { interfaces { fields { type { interfaces { name } } } } } }
__schema { types { name} }
__type(name : "t") { name }
a1: __schema { types { name} }
a1: __type(name : "t") { name }
…
benchmark.SchemaTraversalVerificationTest ‑ compareTraversalCounts() graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure23@80bfdc6 delegate=graphql.AssertTest@5ec4ff02 owner=graphql.AssertTest@5ec4ff02 thisObject=graphql.AssertTest@5ec4ff02 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0] graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure24@6edcad64 delegate=graphql.AssertTest@5ec4ff02 owner=graphql.AssertTest@5ec4ff02 thisObject=graphql.AssertTest@5ec4ff02 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1] graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure25@4c6007fb delegate=graphql.AssertTest@5ec4ff02 owner=graphql.AssertTest@5ec4ff02 thisObject=graphql.AssertTest@5ec4ff02 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2] graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure20@cdb2d95 delegate=graphql.AssertTest@5ec4ff02 owner=graphql.AssertTest@5ec4ff02 thisObject=graphql.AssertTest@5ec4ff02 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0] graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure21@122d6c22 delegate=graphql.AssertTest@5ec4ff02 owner=graphql.AssertTest@5ec4ff02 thisObject=graphql.AssertTest@5ec4ff02 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1] graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure22@2f5ac102 delegate=graphql.AssertTest@5ec4ff02 owner=graphql.AssertTest@5ec4ff02 thisObject=graphql.AssertTest@5ec4ff02 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2] graphql.AssertTest ‑ assertNotNull with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure3@75483843 delegate=graphql.AssertTest@5ec4ff02 owner=graphql.AssertTest@5ec4ff02 thisObject=graphql.AssertTest@5ec4ff02 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0] graphql.AssertTest ‑ assertNotNull with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure4@36417a54 delegate=graphql.AssertTest@5ec4ff02 owner=graphql.AssertTest@5ec4ff02 thisObject=graphql.AssertTest@5ec4ff02 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1] graphql.AssertTest ‑ assertNotNull with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure5@4b6d92e delegate=graphql.AssertTest@5ec4ff02 owner=graphql.AssertTest@5ec4ff02 thisObject=graphql.AssertTest@5ec4ff02 resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2] … ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Hello, this pull request has been inactive for 60 days, so we're marking it as stale. If you would like to continue working on this pull request, please make an update within the next 30 days, or we'll close the pull request. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Hello, as this pull request has been inactive for 90 days, we're closing this pull request. We always welcome contributions, and if you would like to continue, please open a new pull request. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.